You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2017/07/24 16:05:47 UTC
[GitHub] tinkerpop pull request #680: TINKERPOP-1692 Neo4j 3.2.2
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/680
TINKERPOP-1692 Neo4j 3.2.2
https://issues.apache.org/jira/browse/TINKERPOP-1692
Bumps to Neo4j 3.2.2 and is the revision to #674 which needed some additional `pom.xml` work. That's the only real change here. Going forward for review/vote purposes, we'll use this PR over the other one.
Running full tests now....will udpate when complete.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1692
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/680.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #680
----
commit 71d772e06a53fc1ada24d6db433ce2bbace5a6b0
Author: Michael Hunger <gi...@jexp.de>
Date: 2017-07-13T00:19:57Z
fixes for neo4j upgrade to 3.2.2
commit a348a05b1d3e13396ff0a539c90b227bde3d0360
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-07-24T15:28:05Z
Merge branch 'pr-674' into TINKERPOP-1692
commit a692960c687c393e3089a5d66c829e91290d2b2f
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2017-07-24T15:56:56Z
TINKERPOP-1692 Cleaned up enforcer for neo4j
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by jexp <gi...@git.apache.org>.
Github user jexp commented on the issue:
https://github.com/apache/tinkerpop/pull/680
I didn't see a released 3.3.0 version of tp3 on maven central, that's why I used 3.2.5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/680
VOTE: +1
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by jexp <gi...@git.apache.org>.
Github user jexp commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@robertdale I did the split of the project into two modules which have been published separately, please have a look.
http://search.maven.org/#artifactdetails%7Corg.neo4j%7Cneo4j-tinkerpop-api-impl%7C0.7-3.2.3%7Cjar
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
Pulled in @jexp latest changes. This depends on SNAPSHOT versions both ways (cyclic dependencies) so we'll need to update both sides to release versions at release time.
`mvn clean install -pl neo4j-gremlin -am -ff -DskipIntegrationTests=false -DincludeNeo4j ` BUILD SUCCESS
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
All better now. Verified new index and cluster property settings.
VOTE +1 again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
Hmm... so just to reiterate and be super clear the desire is to have Neo4j 3.2.2 on TinkerPop 3.3.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
The original request was to upgrade on TinkerPop 3.3 on https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/issues/6 . I think with Neo4j and TinkerPop being on similar 3.x.y version schemes, that it got mixed up.
@jexp Did you perhaps have another api-impl branch based on TinkerPop 3.3.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
confused - does this mean this PR should target 3.2.2? or is there a neo4j-tinkerpop-api-impl 0.6-3.3.0 to use?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@spmallette I think the right way to do it is for @jexp to pull out that neo4j/gremlin procedure into its own, separate module. That's what creates the cyclic dependency on tinkerpop. Then a proper release of neo4j-tinkerpop-api-impl can be made. @jexp thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
ok - well, i'll leave this branch where it is and let you roll with it then. if you want me to just close it, then let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by jexp <gi...@git.apache.org>.
Github user jexp commented on the issue:
https://github.com/apache/tinkerpop/pull/680
I pushed a branch here: https://github.com/neo4j-contrib/neo4j-tinkerpop-api-impl/tree/gremlin-330
and updated the other branch here: https://github.com/jexp/incubator-tinkerpop/commit/30a37b2cbdaabdd825271bd5991a376a254fbd0f
with the version upgrade to 0.7-3.2.2-SNAPSHOT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@robertdale can you offer your thoughts on how you see this working? I don't think we want to merge a SNAPSHOT to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/680
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
I did a rebase to master and messed it up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
@spmallette Sorry I haven't commented earlier. I don't think this is right. This PR is using neo4j-tinkerpop-api-impl 0.6-3.2.2 which uses gremlin 3.2.5. However, master is gremlin 3.3.0-SNAPSHOT.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/680
3.3.0 is still SNAPSHOT only. it won't release for another couple of weeks or so i imagine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #680: TINKERPOP-1692 Neo4j 3.2.2
Posted by robertdale <gi...@git.apache.org>.
Github user robertdale commented on the issue:
https://github.com/apache/tinkerpop/pull/680
`docker/build.sh -i -t -n` SUCCESS
VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---