You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2015/09/01 02:55:47 UTC
Review Request 37979: Prompt user to save checkpoint before shutdown
if last checkpoint is too old
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37979/
-----------------------------------------------------------
Review request for Ambari and Yusaku Sako.
Bugs: AMBARI-12951
https://issues.apache.org/jira/browse/AMBARI-12951
Repository: ambari
Description
-------
If the admin attempts to shutdown the HDFS NameNode(s) through Ambari in following situations:
* HDFS service > Stop / Restart All components,
* HDFS summary/configs page> Restart Affected,
* Host Details > NameNode Stop / Restart,
* Host Details > Stop/Restart all components,
* Stop All Services,
* Hosts Actions > All/Selected/Filtered Hosts > Hosts > Stop/Restart All Components,
A check should be run to see when the last HDFS checkpoint was created.
If the checkpoint was created more than 12 hours ago, Ambari should prompt the user to save/create a checkpoint first.
"The last HDFS checkpoint is older than 12 hours. Make sure that you have taken a checkpoint before proceeding. Otherwise, the NameNode(s) can take a very long time to start up."
The check should be skipped if there's no NameNode to shut down (i.e., all NameNodes are already down) as a result of the operation.
The user should be warned with instructions to create a new checkpoint, it is up to User if they would like to create a new checkpoint. User can always proceed with button "Next".
The Active NameNode JMX is checked to figure out when the last checkpoint was taken. If the Active NameNode JMX is not available for whatever reason, check for any available NameNode JMX (Standby).
If no JMX info is available, then something is wrong. In this case, display warning along the line of "Could not determine the age of the last HDFS checkpoint. Please ensure that you have a recent checkpoint. Otherwise, the NameNode(s) can take a very long time to start up."
*Limitations*
* NameNode shutdown that are part of any Wizard will not be taken care of in this RMP (e.g., NameNode HA wizard)
Diffs
-----
ambari-web/app/controllers/main/host.js 8bf9065
ambari-web/app/controllers/main/host/details.js adf0c40
ambari-web/app/controllers/main/service.js d1346e4
ambari-web/app/controllers/main/service/info/configs.js 087ef53
ambari-web/app/controllers/main/service/item.js d12164a
ambari-web/app/messages.js 78f51f8
ambari-web/app/utils/ajax/ajax.js b1542c9
ambari-web/app/views/main/service/info/summary.js 4e58bda
ambari-web/test/controllers/main/service/item_test.js 46e7512
Diff: https://reviews.apache.org/r/37979/diff/
Testing
-------
UNIT Tests passed.
Tested all situations in Description e2e.
Thanks,
Xi Wang
Re: Review Request 37979: Prompt user to save checkpoint before
shutdown if last checkpoint is too old
Posted by Xi Wang <xw...@hortonworks.com>.
> On Sept. 1, 2015, 3:49 p.m., Yusaku Sako wrote:
> > This looks good. We can commit this, but let's have two follow-up actions.
> > * Create a JIRA to add unit tests for all different scenarios mentioned.
> > * Create a JIRA for making the HDFS username portion of the checkpoint command description dynamic (the user can customize the HDFS username).
>
> Xi Wang wrote:
> Created https://hortonworks.jira.com/browse/BUG-43690, and https://hortonworks.jira.com/browse/BUG-43692 to address the issues mentioned above.
Created JIRAs: https://issues.apache.org/jira/browse/AMBARI-12966 and https://issues.apache.org/jira/browse/AMBARI-12967 to address the mentioned issues above.
- Xi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37979/#review97357
-----------------------------------------------------------
On Aug. 31, 2015, 5:55 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37979/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 5:55 p.m.)
>
>
> Review request for Ambari and Yusaku Sako.
>
>
> Bugs: AMBARI-12951
> https://issues.apache.org/jira/browse/AMBARI-12951
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If the admin attempts to shutdown the HDFS NameNode(s) through Ambari in following situations:
>
> * HDFS service > Stop / Restart All components,
> * HDFS summary/configs page> Restart Affected,
> * Host Details > NameNode Stop / Restart,
> * Host Details > Stop/Restart all components,
> * Stop All Services,
> * Hosts Actions > All/Selected/Filtered Hosts > Hosts > Stop/Restart All Components,
>
> A check should be run to see when the last HDFS checkpoint was created.
>
> If the checkpoint was created more than 12 hours ago, Ambari should prompt the user to save/create a checkpoint first.
> "The last HDFS checkpoint is older than 12 hours. Make sure that you have taken a checkpoint before proceeding. Otherwise, the NameNode(s) can take a very long time to start up."
>
> The check should be skipped if there's no NameNode to shut down (i.e., all NameNodes are already down) as a result of the operation.
>
> The user should be warned with instructions to create a new checkpoint, it is up to User if they would like to create a new checkpoint. User can always proceed with button "Next".
>
> The Active NameNode JMX is checked to figure out when the last checkpoint was taken. If the Active NameNode JMX is not available for whatever reason, check for any available NameNode JMX (Standby).
>
> If no JMX info is available, then something is wrong. In this case, display warning along the line of "Could not determine the age of the last HDFS checkpoint. Please ensure that you have a recent checkpoint. Otherwise, the NameNode(s) can take a very long time to start up."
>
> *Limitations*
> * NameNode shutdown that are part of any Wizard will not be taken care of in this RMP (e.g., NameNode HA wizard)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 8bf9065
> ambari-web/app/controllers/main/host/details.js adf0c40
> ambari-web/app/controllers/main/service.js d1346e4
> ambari-web/app/controllers/main/service/info/configs.js 087ef53
> ambari-web/app/controllers/main/service/item.js d12164a
> ambari-web/app/messages.js 78f51f8
> ambari-web/app/utils/ajax/ajax.js b1542c9
> ambari-web/app/views/main/service/info/summary.js 4e58bda
> ambari-web/test/controllers/main/service/item_test.js 46e7512
>
> Diff: https://reviews.apache.org/r/37979/diff/
>
>
> Testing
> -------
>
> UNIT Tests passed.
> Tested all situations in Description e2e.
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 37979: Prompt user to save checkpoint before
shutdown if last checkpoint is too old
Posted by Xi Wang <xw...@hortonworks.com>.
> On Sept. 1, 2015, 3:49 p.m., Yusaku Sako wrote:
> > This looks good. We can commit this, but let's have two follow-up actions.
> > * Create a JIRA to add unit tests for all different scenarios mentioned.
> > * Create a JIRA for making the HDFS username portion of the checkpoint command description dynamic (the user can customize the HDFS username).
Created https://hortonworks.jira.com/browse/BUG-43690, and https://hortonworks.jira.com/browse/BUG-43692 to address the issues mentioned above.
- Xi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37979/#review97357
-----------------------------------------------------------
On Aug. 31, 2015, 5:55 p.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37979/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 5:55 p.m.)
>
>
> Review request for Ambari and Yusaku Sako.
>
>
> Bugs: AMBARI-12951
> https://issues.apache.org/jira/browse/AMBARI-12951
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If the admin attempts to shutdown the HDFS NameNode(s) through Ambari in following situations:
>
> * HDFS service > Stop / Restart All components,
> * HDFS summary/configs page> Restart Affected,
> * Host Details > NameNode Stop / Restart,
> * Host Details > Stop/Restart all components,
> * Stop All Services,
> * Hosts Actions > All/Selected/Filtered Hosts > Hosts > Stop/Restart All Components,
>
> A check should be run to see when the last HDFS checkpoint was created.
>
> If the checkpoint was created more than 12 hours ago, Ambari should prompt the user to save/create a checkpoint first.
> "The last HDFS checkpoint is older than 12 hours. Make sure that you have taken a checkpoint before proceeding. Otherwise, the NameNode(s) can take a very long time to start up."
>
> The check should be skipped if there's no NameNode to shut down (i.e., all NameNodes are already down) as a result of the operation.
>
> The user should be warned with instructions to create a new checkpoint, it is up to User if they would like to create a new checkpoint. User can always proceed with button "Next".
>
> The Active NameNode JMX is checked to figure out when the last checkpoint was taken. If the Active NameNode JMX is not available for whatever reason, check for any available NameNode JMX (Standby).
>
> If no JMX info is available, then something is wrong. In this case, display warning along the line of "Could not determine the age of the last HDFS checkpoint. Please ensure that you have a recent checkpoint. Otherwise, the NameNode(s) can take a very long time to start up."
>
> *Limitations*
> * NameNode shutdown that are part of any Wizard will not be taken care of in this RMP (e.g., NameNode HA wizard)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 8bf9065
> ambari-web/app/controllers/main/host/details.js adf0c40
> ambari-web/app/controllers/main/service.js d1346e4
> ambari-web/app/controllers/main/service/info/configs.js 087ef53
> ambari-web/app/controllers/main/service/item.js d12164a
> ambari-web/app/messages.js 78f51f8
> ambari-web/app/utils/ajax/ajax.js b1542c9
> ambari-web/app/views/main/service/info/summary.js 4e58bda
> ambari-web/test/controllers/main/service/item_test.js 46e7512
>
> Diff: https://reviews.apache.org/r/37979/diff/
>
>
> Testing
> -------
>
> UNIT Tests passed.
> Tested all situations in Description e2e.
>
>
> Thanks,
>
> Xi Wang
>
>
Re: Review Request 37979: Prompt user to save checkpoint before
shutdown if last checkpoint is too old
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37979/#review97357
-----------------------------------------------------------
Ship it!
This looks good. We can commit this, but let's have two follow-up actions.
* Create a JIRA to add unit tests for all different scenarios mentioned.
* Create a JIRA for making the HDFS username portion of the checkpoint command description dynamic (the user can customize the HDFS username).
- Yusaku Sako
On Sept. 1, 2015, 12:55 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37979/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 12:55 a.m.)
>
>
> Review request for Ambari and Yusaku Sako.
>
>
> Bugs: AMBARI-12951
> https://issues.apache.org/jira/browse/AMBARI-12951
>
>
> Repository: ambari
>
>
> Description
> -------
>
> If the admin attempts to shutdown the HDFS NameNode(s) through Ambari in following situations:
>
> * HDFS service > Stop / Restart All components,
> * HDFS summary/configs page> Restart Affected,
> * Host Details > NameNode Stop / Restart,
> * Host Details > Stop/Restart all components,
> * Stop All Services,
> * Hosts Actions > All/Selected/Filtered Hosts > Hosts > Stop/Restart All Components,
>
> A check should be run to see when the last HDFS checkpoint was created.
>
> If the checkpoint was created more than 12 hours ago, Ambari should prompt the user to save/create a checkpoint first.
> "The last HDFS checkpoint is older than 12 hours. Make sure that you have taken a checkpoint before proceeding. Otherwise, the NameNode(s) can take a very long time to start up."
>
> The check should be skipped if there's no NameNode to shut down (i.e., all NameNodes are already down) as a result of the operation.
>
> The user should be warned with instructions to create a new checkpoint, it is up to User if they would like to create a new checkpoint. User can always proceed with button "Next".
>
> The Active NameNode JMX is checked to figure out when the last checkpoint was taken. If the Active NameNode JMX is not available for whatever reason, check for any available NameNode JMX (Standby).
>
> If no JMX info is available, then something is wrong. In this case, display warning along the line of "Could not determine the age of the last HDFS checkpoint. Please ensure that you have a recent checkpoint. Otherwise, the NameNode(s) can take a very long time to start up."
>
> *Limitations*
> * NameNode shutdown that are part of any Wizard will not be taken care of in this RMP (e.g., NameNode HA wizard)
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/host.js 8bf9065
> ambari-web/app/controllers/main/host/details.js adf0c40
> ambari-web/app/controllers/main/service.js d1346e4
> ambari-web/app/controllers/main/service/info/configs.js 087ef53
> ambari-web/app/controllers/main/service/item.js d12164a
> ambari-web/app/messages.js 78f51f8
> ambari-web/app/utils/ajax/ajax.js b1542c9
> ambari-web/app/views/main/service/info/summary.js 4e58bda
> ambari-web/test/controllers/main/service/item_test.js 46e7512
>
> Diff: https://reviews.apache.org/r/37979/diff/
>
>
> Testing
> -------
>
> UNIT Tests passed.
> Tested all situations in Description e2e.
>
>
> Thanks,
>
> Xi Wang
>
>