You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Jason Gerlowski (Jira)" <ji...@apache.org> on 2023/01/03 15:14:00 UTC
[jira] [Commented] (SOLR-10455) setParser should be deprecated in favor of SolrClientBuilder methods
[ https://issues.apache.org/jira/browse/SOLR-10455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654057#comment-17654057 ]
Jason Gerlowski commented on SOLR-10455:
----------------------------------------
Great work [~epugh]! One question/suggestion:
The Javadocs on the (now deprecated) {{setParser}} method pointed to where users could go on {{SolrRequest}} if they needed to override the default ResponseParser for a particular request. AFAICT, that detail didn't make it into the javadocs that you added for {{SolrClientBuilder.withResponseParser}}. Was there a particular reason for this, or was it just oversight?
IMO it's an important detail to keep around. Solr has some APIs that only support a subset of response formats, and I'd hate to see unaware users create new clients just to handle these cases.
I'd be happy to take a crack at updating those javadocs, assuming the omission was unintentional? Let me know!
> setParser should be deprecated in favor of SolrClientBuilder methods
> --------------------------------------------------------------------
>
> Key: SOLR-10455
> URL: https://issues.apache.org/jira/browse/SOLR-10455
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Reporter: Jason Gerlowski
> Assignee: Eric Pugh
> Priority: Minor
> Fix For: 7.0, 9.2
>
>
> Now that builders are in place for {{SolrClients}}, the setters used in each {{SolrClient}} can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:
> - unifies {{SolrClient}} configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak {{SolrClient}}s available in a single place (the Builders).
> - reduces {{SolrClient}} thread-safety concerns. Currently, clients are mutable. Using some {{SolrClient}} setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.
> This subtask endeavors to change this behavior for the {{setParser}} setter on all {{SolrClient}} implementations.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org