[jira] [Commented] (TAJO-839) If all tables participate in the BROADCAST JOIN, there is some missing data.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016628#comment-14016628 ] 

ASF GitHub Bot commented on TAJO-839:
-------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/17#discussion_r13340790
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/engine/planner/PhysicalPlannerImpl.java ---
    @@ -844,16 +844,15 @@ private boolean checkIfSortEquivalance(TaskAttemptContext ctx, ScanNode scanNode
     
       public PhysicalExec createScanPlan(TaskAttemptContext ctx, ScanNode scanNode, Stack<LogicalNode> node)
           throws IOException {
    -    if (ctx.getTable(scanNode.getCanonicalName()) == null) {
    -      return new SeqScanExec(ctx, sm, scanNode, null);
    -    }
    -    Preconditions.checkNotNull(ctx.getTable(scanNode.getCanonicalName()),
    -        "Error: There is no table matched to %s", scanNode.getCanonicalName() + "(" + scanNode.getTableName() + ")");    
    -
         // check if an input is sorted in the same order to the subsequence sort operator.
         // TODO - it works only if input files are raw files. We should check the file format.
         // Since the default intermediate file format is raw file, it is not problem right now.
         if (checkIfSortEquivalance(ctx, scanNode, node)) {
    +      if (ctx.getTable(scanNode.getCanonicalName()) == null) {
    +        return new SeqScanExec(ctx, sm, scanNode, null);
    +      }
    +      Preconditions.checkNotNull(ctx.getTable(scanNode.getCanonicalName()),
    --- End diff --
    
    It seems unnecessary because the above if clause checks the same condition.


> If all tables participate in the BROADCAST JOIN, there is some missing data.
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-839
>                 URL: https://issues.apache.org/jira/browse/TAJO-839
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Hyoungjun Kim
>            Assignee: Hyoungjun Kim
>            Priority: Minor
>
> See title. 
> If all tables participate in the BROADCAST JOIN and table has several files, there is some missing data.



--
This message was sent by Atlassian JIRA
(v6.2#6252)