You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2010/08/25 15:29:16 UTC
[jira] Created: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
The dynamic snitch can't be used with network topology strategies
-----------------------------------------------------------------
Key: CASSANDRA-1429
URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7 beta 1
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Fix For: 0.7 beta 2
Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1429:
--------------------------------------
Attachment: 1429-v2.txt
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902475#action_12902475 ]
Sylvain Lebresne commented on CASSANDRA-1429:
---------------------------------------------
I agree the second patch is a better alternative. But I think that the casts to AbstractNetworkTopologySnitch in DatacenterWriteResponseHandler.java, /DatacenterSyncWriteResponseHandler.java and DatacenterQuorumResponseHandler.java should also go away.
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1429:
--------------------------------------
Fix Version/s: 0.6.6
Affects Version/s: 0.6.5
Description: also ported to 0.6 and committed there
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.6.5, 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Jonathan Ellis
> Fix For: 0.6.6, 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
> also ported to 0.6 and committed there
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1429:
--------------------------------------
Attachment: 1429-v2.txt
this breaks DES, the whole point is that it uses a different sort than ANTS.
the right fix is to get rid of the obsolete casts in the Strategy classes, the methods they want are all on IES now.
attached.
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-1429:
----------------------------------------
Attachment: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1429:
--------------------------------------
Attachment: (was: 1429-v2.txt)
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1429) The dynamic snitch can't be used
with network topology strategies
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1429.
---------------------------------------
Assignee: Jonathan Ellis (was: Sylvain Lebresne)
Reviewer: slebresne
Resolution: Fixed
(for the record, as discussed in IRC, I was wrong about Sylvain's original patch breaking DES)
Committed v2 w/ above changes
> The dynamic snitch can't be used with network topology strategies
> -----------------------------------------------------------------
>
> Key: CASSANDRA-1429
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1429
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7 beta 1
> Reporter: Sylvain Lebresne
> Assignee: Jonathan Ellis
> Fix For: 0.7 beta 2
>
> Attachments: 0001-Make-DynamicEndpointSnitch-a-subclass-of-AbstractNet.patch, 1429-v2.txt
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.