You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/11/10 10:28:49 UTC

[GitHub] [zeppelin] Reamer commented on a diff in pull request #4503: [ZEPPELIN-5842] Maven-Plugin management

Reamer commented on code in PR #4503:
URL: https://github.com/apache/zeppelin/pull/4503#discussion_r1018923993


##########
zeppelin-integration/pom.xml:
##########
@@ -37,14 +37,9 @@
   </prerequisites>
 
   <properties>
-    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Review Comment:
   You are right, we should add `project.build.sourceEncoding` in root pom.xml. Please keep in mind that this change also affects other plugins. For example the compiler plugin https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#encoding.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org