[GitHub] mistercrunch commented on a change in pull request #6044: Bump FAB to 1.12.0

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #6044: Bump FAB to 1.12.0
URL: https://github.com/apache/incubator-superset/pull/6044#discussion_r223225323
 
 

 ##########
 File path: setup.py
 ##########
 @@ -67,7 +67,7 @@ def get_git_sha():
         'contextlib2',
         'cryptography',
         'flask<1.0.0',
-        'flask-appbuilder==1.10.0',  # known db migration with 1.11+
+        'flask-appbuilder==1.12.0',
 
 Review comment:
   There's been numerous conversations about this in the past. @john-bodley advocated to have both the more open `setup.py` and pinned `requirements.txt`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org