You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/06 10:35:26 UTC
[GitHub] [airflow] waleedsamy opened a new issue #16285: Airflow >= 2.3 doesn't retry a task if it eternally killed
waleedsamy opened a new issue #16285:
URL: https://github.com/apache/airflow/issues/16285
<!--
Welcome to Apache Airflow! For a smooth issue process, try to answer the following questions.
Don't worry if they're not all applicable; just try to include what you can :-)
If you need to include code snippets or logs, please put them in fenced code
blocks. If they're super-long, please use the details tag like
<details><summary>super-long log</summary> lots of stuff </details>
Please delete these comment blocks before submitting the issue.
-->
<!--
IMPORTANT!!!
PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
Please complete the next sections or the issue will be closed.
These questions are the first thing we need to know to understand the context.
-->
**Apache Airflow version**: >= 2.3
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**:
- **Cloud provider or hardware configuration**:
- **OS** (e.g. from /etc/os-release): Ubuntu 18.04.5 LTS
- **Kernel** (e.g. `uname -a`): Linux 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
- **Install tools**: pip
- **Others**:
**What happened**:
When a task get externally killed, it is marked as Failed even though it can be retried.
<!-- (please include exact error messages if you can) -->
**What you expected to happen**:
When a task get externally killed (kill -9 pid), it should put back to retry if it `retries` did not run out yet.
<!-- What do you think went wrong? -->
**How to reproduce it**:
I'm using Celery as executor and I have a cluster of ~250 machine.
I have a task that defined as next. When the task started to execute, and it get killed externally by sending SIGKILL to it (or to the executor process and it's children), it get marked as FAILED and doesn't put to retry (even though retries is set to 10 times)
```
import time
def _task1(ts_nodash, dag_run, ti, **context):
time.sleep(300)
tasks = PythonOperator(
task_id='task1',
python_callable=_task1,
retries=10,
dag=dag1
)
```
<!---
As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
## Install minikube/kind
- Minikube https://minikube.sigs.k8s.io/docs/start/
- Kind https://kind.sigs.k8s.io/docs/user/quick-start/
If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
You can include images using the .md style of
To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
--->
**Anything else we need to know**: This bug is introduced by [15537](https://github.com/apache/airflow/pull/15537/files#diff-d80fa918cc75c4d6aa582d5e29eeb812ba21371d6977fde45a4749668b79a515R159) as far as I know.
<!--
How often does this problem occur? Once? Every time etc? Every time
Any relevant logs to include? Put them here in side a detail tag:
<details><summary>x.log</summary> lots of stuff </details>
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] waleedsamy commented on issue #16285: Airflow >= 2.3 doesn't retry a task if it eternally killed
Posted by GitBox <gi...@apache.org>.
waleedsamy commented on issue #16285:
URL: https://github.com/apache/airflow/issues/16285#issuecomment-855376533
CC @ashb @ephraimbuddy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy closed issue #16285: Airflow 2.1.0 doesn't retry a task if it externally killed
Posted by GitBox <gi...@apache.org>.
ephraimbuddy closed issue #16285:
URL: https://github.com/apache/airflow/issues/16285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org