You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simone Tripodi <si...@apache.org> on 2011/10/25 22:10:29 UTC

[VOTE] Release Apache Commons-Digester 3.1 based on RC2

Hi all guys,
I'm writing to call for a vote to release apache commons-digester-3.1
based on RC2.

This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
Please take in consideration that broken 3.1 links will be fixed once
the site will be deployed.

The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.

Many thanks in advance for reviewing, have a nice day!
All the best,
Simo

Release notes:

 http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt

Tag:

 https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/

Site:

 http://people.apache.org/builds/commons/digester/3.1/RC2/site/

Binaries:

 http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/

Maven Artifacts (staged on Nexus)

 https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/

[ ] +1 release it
[ ] +0 go ahead I don't care
[ ] -1 no, do not release it because... (please explain why)

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Oliver Heger <ol...@oliver-heger.de>.
Build works fine with Java 1.5 on Windows 7. Artifacts and site look good.

The checkstyle issue really is not a blocker.

So +1, good work!
Oliver

Am 25.10.2011 22:10, schrieb Simone Tripodi:
> Hi all guys,
> I'm writing to call for a vote to release apache commons-digester-3.1
> based on RC2.
>
> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
> Please take in consideration that broken 3.1 links will be fixed once
> the site will be deployed.
>
> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.
>
> Many thanks in advance for reviewing, have a nice day!
> All the best,
> Simo
>
> Release notes:
>
>   http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>
> Tag:
>
>   https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>
> Site:
>
>   http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>
> Binaries:
>
>   http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>
> Maven Artifacts (staged on Nexus)
>
>   https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because... (please explain why)
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Thanks for reviewing Oliver :)
Just to avoid mistakes, I already fixed it so for next RCs there won't
be mistakes anymore :P
Alles gute!
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Oct 26, 2011 at 9:50 PM, Oliver Heger
<ol...@oliver-heger.de> wrote:
> Am 26.10.2011 09:42, schrieb Simone Tripodi:
>>>>
>>>> [X] +1 release it
>>>
>>> There is one glitch, but not blocking: the checkstyle-suppressions.xml
>>> file is not included in the source distribution (it is not in the
>>> /src/main/assembly/src.xml configuration file), so when rebuilding from
>>> the source archive triggers many checkstyle errors in the report.
>>>
>>
>> Ack, going to fix it right now before I forget! :)
>> Thanks a lot for reviewing, all the best!
>> Simo
>
> This is the explanation for the mysterious checkstyle errors I got!
>
> Oliver
>
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Oliver Heger <ol...@oliver-heger.de>.
Am 26.10.2011 09:42, schrieb Simone Tripodi:
>>>
>>> [X] +1 release it
>>
>> There is one glitch, but not blocking: the checkstyle-suppressions.xml
>> file is not included in the source distribution (it is not in the
>> /src/main/assembly/src.xml configuration file), so when rebuilding from
>> the source archive triggers many checkstyle errors in the report.
>>
>
> Ack, going to fix it right now before I forget! :)
> Thanks a lot for reviewing, all the best!
> Simo

This is the explanation for the mysterious checkstyle errors I got!

Oliver

>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
>>
>> [X] +1 release it
>
> There is one glitch, but not blocking: the checkstyle-suppressions.xml
> file is not included in the source distribution (it is not in the
> /src/main/assembly/src.xml configuration file), so when rebuilding from
> the source archive triggers many checkstyle errors in the report.
>

Ack, going to fix it right now before I forget! :)
Thanks a lot for reviewing, all the best!
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Luc Maisonobe <Lu...@free.fr>.
Le 25/10/2011 22:10, Simone Tripodi a écrit :
> Hi all guys,
> I'm writing to call for a vote to release apache commons-digester-3.1
> based on RC2.
> 
> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
> Please take in consideration that broken 3.1 links will be fixed once
> the site will be deployed.
> 
> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.
> 
> Many thanks in advance for reviewing, have a nice day!
> All the best,
> Simo
> 
> Release notes:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
> 
> Tag:
> 
>  https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
> 
> Site:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
> 
> Binaries:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
> 
> Maven Artifacts (staged on Nexus)
> 
>  https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
> 
> [X] +1 release it

There is one glitch, but not blocking: the checkstyle-suppressions.xml
file is not included in the source distribution (it is not in the
/src/main/assembly/src.xml configuration file), so when rebuilding from
the source archive triggers many checkstyle errors in the report.

Luc

> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because... (please explain why)
> 
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


[RESULT][VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Hi all guys,
Since 72 hours passed I'm declaring this vote as closed and passed
with 3 positive votes from PMCs:

 * Simone Tripodi
 * Luc Maisonobe
 * Oliver Heger

no other votes were cast.

I'll move the proposed release to dist/ and give 24 hours for mirrors
to sync before making ANN and site update.

Thanks to all for your support and patience!
Have a nice weekend, all the best!
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Thu, Oct 27, 2011 at 9:00 AM, Simone Tripodi
<si...@apache.org> wrote:
> Hi Gary!!
> I tried to force the PMD plugin to version 2.5 in the Digester
> pom.xml, unfortunately looking at the effective pom I realized that
> the site-plugin-3.0 continues using the pmd-plugin-2.3, because it is
> configured inside the reportset :(
> I'll have a deep look at the site-plugin.
> Thanks for the hint!
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Thu, Oct 27, 2011 at 12:54 AM, Gary Gregory <ga...@gmail.com> wrote:
>> Simo,
>>
>> I'm on my phone ATM so I cannot check this, but are you using the
>> latest versions of the plugins? Maybe some of these false positives
>> would go away.
>>
>> Gary
>>
>> On Oct 25, 2011, at 17:39, Simone Tripodi <si...@apache.org> wrote:
>>
>>> Hi Gary!
>>>
>>> That is the same I wondered: if 6 are "too many", how many are enough? :)
>>> Maybe it's time PMD updates its rules? :P
>>>
>>> About the other PMD violations:
>>>
>>> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
>>> true, it is used:
>>>
>>> 2624     public <T> T peek()
>>> 2625     {
>>> 2626         try
>>> 2627         {
>>> 2628             return this.<T> npeSafeCast( stack.peek() );
>>> 2629         }
>>> 2630         catch ( EmptyStackException e )
>>> 2631         {
>>> 2632             log.warn( "Empty stack (returning null)" );
>>> 2633             return ( null );
>>> 2634         }
>>> 2635     }
>>>
>>> `Overriding method merely calls super` is not true, it returns a
>>> method chain that involves the super:
>>>
>>> 49      @Override
>>> 50      protected LinkedRuleBuilder forPattern( String pattern )
>>> 51      {
>>> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
>>> 53      }
>>>
>>> `Avoid empty catch blocks` is the same that we have in IO:
>>>
>>> 77              try
>>> 78              {
>>> 79                  if ( s != null )
>>> 80                  {
>>> 81                      s.close();
>>> 82                  }
>>> 83              }
>>> 84              catch ( IOException e )
>>> 85              {
>>> 86                  // close quietly
>>> 87              }
>>>
>>> Thanks for reviewing, hope this clarifies and you will express a +1 :P
>>> All the best,
>>> Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>>
>>>
>>> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>> Hi Simo,
>>>>
>>>> Not blockers but the PMD issues could be addressed except:
>>>>
>>>> Should we turn off "Too many static imports may lead to messy code"? How
>>>> many is too many?
>>>>
>>>> Gary
>>>>
>>>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>>>
>>>>> Hi all guys,
>>>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>>>> based on RC2.
>>>>>
>>>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>>>> call.
>>>>> Please take in consideration that broken 3.1 links will be fixed once
>>>>> the site will be deployed.
>>>>>
>>>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>>>> CET.
>>>>>
>>>>> Many thanks in advance for reviewing, have a nice day!
>>>>> All the best,
>>>>> Simo
>>>>>
>>>>> Release notes:
>>>>>
>>>>>
>>>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>>>
>>>>> Tag:
>>>>>
>>>>>
>>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>>>
>>>>> Site:
>>>>>
>>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>>>
>>>>> Binaries:
>>>>>
>>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>>>
>>>>> Maven Artifacts (staged on Nexus)
>>>>>
>>>>>
>>>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>>>
>>>>> [ ] +1 release it
>>>>> [ ] +0 go ahead I don't care
>>>>> [ ] -1 no, do not release it because... (please explain why)
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>>>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Hi Gary!!
I tried to force the PMD plugin to version 2.5 in the Digester
pom.xml, unfortunately looking at the effective pom I realized that
the site-plugin-3.0 continues using the pmd-plugin-2.3, because it is
configured inside the reportset :(
I'll have a deep look at the site-plugin.
Thanks for the hint!
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Thu, Oct 27, 2011 at 12:54 AM, Gary Gregory <ga...@gmail.com> wrote:
> Simo,
>
> I'm on my phone ATM so I cannot check this, but are you using the
> latest versions of the plugins? Maybe some of these false positives
> would go away.
>
> Gary
>
> On Oct 25, 2011, at 17:39, Simone Tripodi <si...@apache.org> wrote:
>
>> Hi Gary!
>>
>> That is the same I wondered: if 6 are "too many", how many are enough? :)
>> Maybe it's time PMD updates its rules? :P
>>
>> About the other PMD violations:
>>
>> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
>> true, it is used:
>>
>> 2624     public <T> T peek()
>> 2625     {
>> 2626         try
>> 2627         {
>> 2628             return this.<T> npeSafeCast( stack.peek() );
>> 2629         }
>> 2630         catch ( EmptyStackException e )
>> 2631         {
>> 2632             log.warn( "Empty stack (returning null)" );
>> 2633             return ( null );
>> 2634         }
>> 2635     }
>>
>> `Overriding method merely calls super` is not true, it returns a
>> method chain that involves the super:
>>
>> 49      @Override
>> 50      protected LinkedRuleBuilder forPattern( String pattern )
>> 51      {
>> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
>> 53      }
>>
>> `Avoid empty catch blocks` is the same that we have in IO:
>>
>> 77              try
>> 78              {
>> 79                  if ( s != null )
>> 80                  {
>> 81                      s.close();
>> 82                  }
>> 83              }
>> 84              catch ( IOException e )
>> 85              {
>> 86                  // close quietly
>> 87              }
>>
>> Thanks for reviewing, hope this clarifies and you will express a +1 :P
>> All the best,
>> Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>>
>> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>>> Hi Simo,
>>>
>>> Not blockers but the PMD issues could be addressed except:
>>>
>>> Should we turn off "Too many static imports may lead to messy code"? How
>>> many is too many?
>>>
>>> Gary
>>>
>>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>>
>>>> Hi all guys,
>>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>>> based on RC2.
>>>>
>>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>>> call.
>>>> Please take in consideration that broken 3.1 links will be fixed once
>>>> the site will be deployed.
>>>>
>>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>>> CET.
>>>>
>>>> Many thanks in advance for reviewing, have a nice day!
>>>> All the best,
>>>> Simo
>>>>
>>>> Release notes:
>>>>
>>>>
>>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>>
>>>> Tag:
>>>>
>>>>
>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>>
>>>> Site:
>>>>
>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>>
>>>> Binaries:
>>>>
>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>>
>>>> Maven Artifacts (staged on Nexus)
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>>
>>>> [ ] +1 release it
>>>> [ ] +0 go ahead I don't care
>>>> [ ] -1 no, do not release it because... (please explain why)
>>>>
>>>> http://people.apache.org/~simonetripodi/
>>>> http://simonetripodi.livejournal.com/
>>>> http://twitter.com/simonetripodi
>>>> http://www.99soft.org/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Gary Gregory <ga...@gmail.com>.
Simo,

I'm on my phone ATM so I cannot check this, but are you using the
latest versions of the plugins? Maybe some of these false positives
would go away.

Gary

On Oct 25, 2011, at 17:39, Simone Tripodi <si...@apache.org> wrote:

> Hi Gary!
>
> That is the same I wondered: if 6 are "too many", how many are enough? :)
> Maybe it's time PMD updates its rules? :P
>
> About the other PMD violations:
>
> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
> true, it is used:
>
> 2624     public <T> T peek()
> 2625     {
> 2626         try
> 2627         {
> 2628             return this.<T> npeSafeCast( stack.peek() );
> 2629         }
> 2630         catch ( EmptyStackException e )
> 2631         {
> 2632             log.warn( "Empty stack (returning null)" );
> 2633             return ( null );
> 2634         }
> 2635     }
>
> `Overriding method merely calls super` is not true, it returns a
> method chain that involves the super:
>
> 49      @Override
> 50      protected LinkedRuleBuilder forPattern( String pattern )
> 51      {
> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
> 53      }
>
> `Avoid empty catch blocks` is the same that we have in IO:
>
> 77              try
> 78              {
> 79                  if ( s != null )
> 80                  {
> 81                      s.close();
> 82                  }
> 83              }
> 84              catch ( IOException e )
> 85              {
> 86                  // close quietly
> 87              }
>
> Thanks for reviewing, hope this clarifies and you will express a +1 :P
> All the best,
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>> Hi Simo,
>>
>> Not blockers but the PMD issues could be addressed except:
>>
>> Should we turn off "Too many static imports may lead to messy code"? How
>> many is too many?
>>
>> Gary
>>
>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>
>>> Hi all guys,
>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>> based on RC2.
>>>
>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>> call.
>>> Please take in consideration that broken 3.1 links will be fixed once
>>> the site will be deployed.
>>>
>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>> CET.
>>>
>>> Many thanks in advance for reviewing, have a nice day!
>>> All the best,
>>> Simo
>>>
>>> Release notes:
>>>
>>>
>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>
>>> Tag:
>>>
>>>
>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>
>>> Site:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>
>>> Binaries:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>
>>> Maven Artifacts (staged on Nexus)
>>>
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because... (please explain why)
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
this is my explicit +1

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Oct 26, 2011 at 12:01 AM, Simone Tripodi
<si...@apache.org> wrote:
> Thanks for the hints David, really appreciated!!
> all the best,
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Tue, Oct 25, 2011 at 11:46 PM, David Karlsen <da...@gmail.com> wrote:
>> You can use http://pmd.sourceforge.net/suppressing.html for
>> suppression of edge-cases like empty catch blocks.
>> The first one is simply a false one (e.g. pmd bug).
>>
>> 2011/10/25 Simone Tripodi <si...@apache.org>:
>>> Hi Gary!
>>>
>>> That is the same I wondered: if 6 are "too many", how many are enough? :)
>>> Maybe it's time PMD updates its rules? :P
>>>
>>> About the other PMD violations:
>>>
>>> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
>>> true, it is used:
>>>
>>> 2624     public <T> T peek()
>>> 2625     {
>>> 2626         try
>>> 2627         {
>>> 2628             return this.<T> npeSafeCast( stack.peek() );
>>> 2629         }
>>> 2630         catch ( EmptyStackException e )
>>> 2631         {
>>> 2632             log.warn( "Empty stack (returning null)" );
>>> 2633             return ( null );
>>> 2634         }
>>> 2635     }
>>>
>>> `Overriding method merely calls super` is not true, it returns a
>>> method chain that involves the super:
>>>
>>> 49      @Override
>>> 50      protected LinkedRuleBuilder forPattern( String pattern )
>>> 51      {
>>> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
>>> 53      }
>>>
>>> `Avoid empty catch blocks` is the same that we have in IO:
>>>
>>> 77              try
>>> 78              {
>>> 79                  if ( s != null )
>>> 80                  {
>>> 81                      s.close();
>>> 82                  }
>>> 83              }
>>> 84              catch ( IOException e )
>>> 85              {
>>> 86                  // close quietly
>>> 87              }
>>>
>>> Thanks for reviewing, hope this clarifies and you will express a +1 :P
>>> All the best,
>>> Simo
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>>
>>>
>>> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>>>> Hi Simo,
>>>>
>>>> Not blockers but the PMD issues could be addressed except:
>>>>
>>>> Should we turn off "Too many static imports may lead to messy code"? How
>>>> many is too many?
>>>>
>>>> Gary
>>>>
>>>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>>>
>>>>> Hi all guys,
>>>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>>>> based on RC2.
>>>>>
>>>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>>>> call.
>>>>> Please take in consideration that broken 3.1 links will be fixed once
>>>>> the site will be deployed.
>>>>>
>>>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>>>> CET.
>>>>>
>>>>> Many thanks in advance for reviewing, have a nice day!
>>>>> All the best,
>>>>> Simo
>>>>>
>>>>> Release notes:
>>>>>
>>>>>
>>>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>>>
>>>>> Tag:
>>>>>
>>>>>
>>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>>>
>>>>> Site:
>>>>>
>>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>>>
>>>>> Binaries:
>>>>>
>>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>>>
>>>>> Maven Artifacts (staged on Nexus)
>>>>>
>>>>>
>>>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>>>
>>>>> [ ] +1 release it
>>>>> [ ] +0 go ahead I don't care
>>>>> [ ] -1 no, do not release it because... (please explain why)
>>>>>
>>>>> http://people.apache.org/~simonetripodi/
>>>>> http://simonetripodi.livejournal.com/
>>>>> http://twitter.com/simonetripodi
>>>>> http://www.99soft.org/
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>>>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>>
>> --
>> --
>> David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Thanks for the hints David, really appreciated!!
all the best,
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Tue, Oct 25, 2011 at 11:46 PM, David Karlsen <da...@gmail.com> wrote:
> You can use http://pmd.sourceforge.net/suppressing.html for
> suppression of edge-cases like empty catch blocks.
> The first one is simply a false one (e.g. pmd bug).
>
> 2011/10/25 Simone Tripodi <si...@apache.org>:
>> Hi Gary!
>>
>> That is the same I wondered: if 6 are "too many", how many are enough? :)
>> Maybe it's time PMD updates its rules? :P
>>
>> About the other PMD violations:
>>
>> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
>> true, it is used:
>>
>> 2624     public <T> T peek()
>> 2625     {
>> 2626         try
>> 2627         {
>> 2628             return this.<T> npeSafeCast( stack.peek() );
>> 2629         }
>> 2630         catch ( EmptyStackException e )
>> 2631         {
>> 2632             log.warn( "Empty stack (returning null)" );
>> 2633             return ( null );
>> 2634         }
>> 2635     }
>>
>> `Overriding method merely calls super` is not true, it returns a
>> method chain that involves the super:
>>
>> 49      @Override
>> 50      protected LinkedRuleBuilder forPattern( String pattern )
>> 51      {
>> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
>> 53      }
>>
>> `Avoid empty catch blocks` is the same that we have in IO:
>>
>> 77              try
>> 78              {
>> 79                  if ( s != null )
>> 80                  {
>> 81                      s.close();
>> 82                  }
>> 83              }
>> 84              catch ( IOException e )
>> 85              {
>> 86                  // close quietly
>> 87              }
>>
>> Thanks for reviewing, hope this clarifies and you will express a +1 :P
>> All the best,
>> Simo
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>>
>>
>> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>>> Hi Simo,
>>>
>>> Not blockers but the PMD issues could be addressed except:
>>>
>>> Should we turn off "Too many static imports may lead to messy code"? How
>>> many is too many?
>>>
>>> Gary
>>>
>>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>>
>>>> Hi all guys,
>>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>>> based on RC2.
>>>>
>>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>>> call.
>>>> Please take in consideration that broken 3.1 links will be fixed once
>>>> the site will be deployed.
>>>>
>>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>>> CET.
>>>>
>>>> Many thanks in advance for reviewing, have a nice day!
>>>> All the best,
>>>> Simo
>>>>
>>>> Release notes:
>>>>
>>>>
>>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>>
>>>> Tag:
>>>>
>>>>
>>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>>
>>>> Site:
>>>>
>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>>
>>>> Binaries:
>>>>
>>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>>
>>>> Maven Artifacts (staged on Nexus)
>>>>
>>>>
>>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>>
>>>> [ ] +1 release it
>>>> [ ] +0 go ahead I don't care
>>>> [ ] -1 no, do not release it because... (please explain why)
>>>>
>>>> http://people.apache.org/~simonetripodi/
>>>> http://simonetripodi.livejournal.com/
>>>> http://twitter.com/simonetripodi
>>>> http://www.99soft.org/
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
>
> --
> --
> David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by David Karlsen <da...@gmail.com>.
You can use http://pmd.sourceforge.net/suppressing.html for
suppression of edge-cases like empty catch blocks.
The first one is simply a false one (e.g. pmd bug).

2011/10/25 Simone Tripodi <si...@apache.org>:
> Hi Gary!
>
> That is the same I wondered: if 6 are "too many", how many are enough? :)
> Maybe it's time PMD updates its rules? :P
>
> About the other PMD violations:
>
> `Avoid unused private methods such as 'npeSafeCast(Object)'` is not
> true, it is used:
>
> 2624     public <T> T peek()
> 2625     {
> 2626         try
> 2627         {
> 2628             return this.<T> npeSafeCast( stack.peek() );
> 2629         }
> 2630         catch ( EmptyStackException e )
> 2631         {
> 2632             log.warn( "Empty stack (returning null)" );
> 2633             return ( null );
> 2634         }
> 2635     }
>
> `Overriding method merely calls super` is not true, it returns a
> method chain that involves the super:
>
> 49      @Override
> 50      protected LinkedRuleBuilder forPattern( String pattern )
> 51      {
> 52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
> 53      }
>
> `Avoid empty catch blocks` is the same that we have in IO:
>
> 77              try
> 78              {
> 79                  if ( s != null )
> 80                  {
> 81                      s.close();
> 82                  }
> 83              }
> 84              catch ( IOException e )
> 85              {
> 86                  // close quietly
> 87              }
>
> Thanks for reviewing, hope this clarifies and you will express a +1 :P
> All the best,
> Simo
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
>
>
> On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
>> Hi Simo,
>>
>> Not blockers but the PMD issues could be addressed except:
>>
>> Should we turn off "Too many static imports may lead to messy code"? How
>> many is too many?
>>
>> Gary
>>
>> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>>
>>> Hi all guys,
>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>> based on RC2.
>>>
>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>>> call.
>>> Please take in consideration that broken 3.1 links will be fixed once
>>> the site will be deployed.
>>>
>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>>> CET.
>>>
>>> Many thanks in advance for reviewing, have a nice day!
>>> All the best,
>>> Simo
>>>
>>> Release notes:
>>>
>>>
>>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>
>>> Tag:
>>>
>>>
>>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>
>>> Site:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>
>>> Binaries:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>
>>> Maven Artifacts (staged on Nexus)
>>>
>>>
>>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because... (please explain why)
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>



-- 
--
David J. M. Karlsen - http://www.linkedin.com/in/davidkarlsen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Hi Gary!

That is the same I wondered: if 6 are "too many", how many are enough? :)
Maybe it's time PMD updates its rules? :P

About the other PMD violations:

`Avoid unused private methods such as 'npeSafeCast(Object)'` is not
true, it is used:

2624     public <T> T peek()
2625     {
2626         try
2627         {
2628             return this.<T> npeSafeCast( stack.peek() );
2629         }
2630         catch ( EmptyStackException e )
2631         {
2632             log.warn( "Empty stack (returning null)" );
2633             return ( null );
2634         }
2635     }

`Overriding method merely calls super` is not true, it returns a
method chain that involves the super:

49      @Override
50      protected LinkedRuleBuilder forPattern( String pattern )
51      {
52          return super.forPattern( pattern ).withNamespaceURI( namespaceURI );
53      }

`Avoid empty catch blocks` is the same that we have in IO:

77              try
78              {
79                  if ( s != null )
80                  {
81                      s.close();
82                  }
83              }
84              catch ( IOException e )
85              {
86                  // close quietly
87              }

Thanks for reviewing, hope this clarifies and you will express a +1 :P
All the best,
Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Tue, Oct 25, 2011 at 11:24 PM, Gary Gregory <ga...@gmail.com> wrote:
> Hi Simo,
>
> Not blockers but the PMD issues could be addressed except:
>
> Should we turn off "Too many static imports may lead to messy code"? How
> many is too many?
>
> Gary
>
> On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:
>
>> Hi all guys,
>> I'm writing to call for a vote to release apache commons-digester-3.1
>> based on RC2.
>>
>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
>> call.
>> Please take in consideration that broken 3.1 links will be fixed once
>> the site will be deployed.
>>
>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
>> CET.
>>
>> Many thanks in advance for reviewing, have a nice day!
>> All the best,
>> Simo
>>
>> Release notes:
>>
>>
>> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>
>> Tag:
>>
>>
>> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>
>> Site:
>>
>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>
>> Binaries:
>>
>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>
>> Maven Artifacts (staged on Nexus)
>>
>>
>> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because... (please explain why)
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Gary Gregory <ga...@gmail.com>.
Hi Simo,

Not blockers but the PMD issues could be addressed except:

Should we turn off "Too many static imports may lead to messy code"? How
many is too many?

Gary

On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi <si...@apache.org>wrote:

> Hi all guys,
> I'm writing to call for a vote to release apache commons-digester-3.1
> based on RC2.
>
> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE
> call.
> Please take in consideration that broken 3.1 links will be fixed once
> the site will be deployed.
>
> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm
> CET.
>
> Many thanks in advance for reviewing, have a nice day!
> All the best,
> Simo
>
> Release notes:
>
>
> http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>
> Tag:
>
>
> https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>
> Site:
>
>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>
> Binaries:
>
>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>
> Maven Artifacts (staged on Nexus)
>
>
> https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because... (please explain why)
>
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Simone Tripodi <si...@apache.org>.
Bonjour Luc!
yes it is the binary folder[1] :)
Thanks a lot in advance for reviewing, have anice day!
Simo

[1] http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/



On Wed, Oct 26, 2011 at 8:59 AM, Luc Maisonobe <Lu...@free.fr> wrote:
> Le 26/10/2011 08:55, Luc Maisonobe a écrit :
>> Le 25/10/2011 22:10, Simone Tripodi a écrit :
>>> Hi all guys,
>>> I'm writing to call for a vote to release apache commons-digester-3.1
>>> based on RC2.
>>
>> I may not be completely awake yet but where are the source tar and zip
>> archives and their signatures ?
>
> I think I found them in the binaries folder ...
>
> Luc
>
>>
>> Luc
>>
>>>
>>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
>>> Please take in consideration that broken 3.1 links will be fixed once
>>> the site will be deployed.
>>>
>>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.
>>>
>>> Many thanks in advance for reviewing, have a nice day!
>>> All the best,
>>> Simo
>>>
>>> Release notes:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>>
>>> Tag:
>>>
>>>  https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>>
>>> Site:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>>
>>> Binaries:
>>>
>>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>>
>>> Maven Artifacts (staged on Nexus)
>>>
>>>  https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>>
>>> [ ] +1 release it
>>> [ ] +0 go ahead I don't care
>>> [ ] -1 no, do not release it because... (please explain why)
>>>
>>> http://people.apache.org/~simonetripodi/
>>> http://simonetripodi.livejournal.com/
>>> http://twitter.com/simonetripodi
>>> http://www.99soft.org/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Luc Maisonobe <Lu...@free.fr>.
Le 26/10/2011 08:55, Luc Maisonobe a écrit :
> Le 25/10/2011 22:10, Simone Tripodi a écrit :
>> Hi all guys,
>> I'm writing to call for a vote to release apache commons-digester-3.1
>> based on RC2.
> 
> I may not be completely awake yet but where are the source tar and zip
> archives and their signatures ?

I think I found them in the binaries folder ...

Luc

> 
> Luc
> 
>>
>> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
>> Please take in consideration that broken 3.1 links will be fixed once
>> the site will be deployed.
>>
>> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.
>>
>> Many thanks in advance for reviewing, have a nice day!
>> All the best,
>> Simo
>>
>> Release notes:
>>
>>  http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
>>
>> Tag:
>>
>>  https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
>>
>> Site:
>>
>>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
>>
>> Binaries:
>>
>>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
>>
>> Maven Artifacts (staged on Nexus)
>>
>>  https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
>>
>> [ ] +1 release it
>> [ ] +0 go ahead I don't care
>> [ ] -1 no, do not release it because... (please explain why)
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

Posted by Luc Maisonobe <Lu...@free.fr>.
Le 25/10/2011 22:10, Simone Tripodi a écrit :
> Hi all guys,
> I'm writing to call for a vote to release apache commons-digester-3.1
> based on RC2.

I may not be completely awake yet but where are the source tar and zip
archives and their signatures ?

Luc

> 
> This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call.
> Please take in consideration that broken 3.1 links will be fixed once
> the site will be deployed.
> 
> The vote will stay open for 72 hours and closes on Friday 28th, at 8:10pm CET.
> 
> Many thanks in advance for reviewing, have a nice day!
> All the best,
> Simo
> 
> Release notes:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/RELEASE-NOTES.txt
> 
> Tag:
> 
>  https://svn.apache.org/repos/asf/commons/proper/digester/tags/DIGESTER3_3_1_RC2/
> 
> Site:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/site/
> 
> Binaries:
> 
>  http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/
> 
> Maven Artifacts (staged on Nexus)
> 
>  https://repository.apache.org/content/repositories/orgapachecommons-098/org/apache/commons/commons-digester3/
> 
> [ ] +1 release it
> [ ] +0 go ahead I don't care
> [ ] -1 no, do not release it because... (please explain why)
> 
> http://people.apache.org/~simonetripodi/
> http://simonetripodi.livejournal.com/
> http://twitter.com/simonetripodi
> http://www.99soft.org/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org