You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/03 13:48:23 UTC
[GitHub] [cordova-browser] raphinesse opened a new pull request #98: Inline browser_parser into Api
raphinesse opened a new pull request #98:
URL: https://github.com/apache/cordova-browser/pull/98
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Reduce (unused) code.
### Description
<!-- Describe your changes in detail -->
- Remove unused stuff from `browser_parser`
- Inline remaining two methods from `browser_parser` into `Api`
This removes the property `parser` from `Api` instances. AFAIK this prop is not documented, so I'd consider it private. But if we would consider it public, this PR would be a major change.
### Testing
<!-- Please describe in detail how you tested your changes. -->
I ran `npm t`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-browser] codecov-commenter commented on pull request #98: Inline browser_parser into Api
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #98:
URL: https://github.com/apache/cordova-browser/pull/98#issuecomment-638289738
# [Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=h1) Report
> Merging [#98](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-browser/commit/16271b4978692163df014eaf3f4ea736305e8e8c&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2 2
Lines 31 31
=======================================
Hits 29 29
Misses 2 2
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=footer). Last update [16271b4...d3d9328](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-browser] codecov-commenter edited a comment on pull request #98: Inline browser_parser into Api
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #98:
URL: https://github.com/apache/cordova-browser/pull/98#issuecomment-638289738
# [Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=h1) Report
> Merging [#98](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-browser/commit/16271b4978692163df014eaf3f4ea736305e8e8c&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 2 2
Lines 31 31
=======================================
Hits 29 29
Misses 2 2
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=footer). Last update [16271b4...d3d9328](https://codecov.io/gh/apache/cordova-browser/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org