Re: [PR] feat: CometExecRule refactor: Unify CometNativeExec creation with Serde in CometOperatorSerde trait [datafusion-comet]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #2768:
URL: https://github.com/apache/datafusion-comet/pull/2768#discussion_r2524090635


##########
spark/src/test/scala/org/apache/spark/sql/comet/CometPlanStabilitySuite.scala:
##########
@@ -102,7 +102,7 @@ trait CometPlanStabilitySuite extends DisableAdaptiveExecutionSuite with TPCDSBa
     val approvedFile = new File(dir, s"$filename.txt")
     val actualFile = new File(tempDir, s"$name.actual.$filename.txt")
     FileUtils.writeStringToFile(actualFile, plan, StandardCharsets.UTF_8)
-    comparePlans("simplified", approvedFile, actualFile)
+    comparePlans(filename, approvedFile, actualFile)

Review Comment:
   unrelated to this PR, but this was incorrect



##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -2108,7 +2108,9 @@ class CometExecSuite extends CometTestBase {
   test("LocalTableScanExec spark fallback") {
     withSQLConf(CometConf.COMET_EXEC_LOCAL_TABLE_SCAN_ENABLED.key -> "false") {
       val df = Seq.range(0, 10).toDF("id")
-      checkSparkAnswerAndFallbackReason(df, "LocalTableScan is not enabled")
+      checkSparkAnswerAndFallbackReason(
+        df,
+        "Native support for operator LocalTableScanExec is disabled")

Review Comment:
   This had to be updated now that we are using consistent method for handling enabled/disabled for all native execs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org