You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by liancheng <gi...@git.apache.org> on 2015/01/09 17:30:11 UTC
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/3980
[SPARK-5177][Build] Adds parameters for specifiying Hive and Scala version in dev/run-tests
This PR adds two environment variables, `AMPLAB_JENKINS_BUILD_SCALA_VERSION` and `AMPLAB_JENKINS_BUILD_HIVE_VERSION`, to control which Hive version and Scala version to test. We can use them to add dedicated Jenkins builders for Hive 0.12.0 and Scala 2.11. Currently, Jenkins PR builder only checks whether Hive 0.12.0 code paths compiles, but tests are not executed. Scala 2.11 is not tested at all.
This PR also removed the Hive 0.12.0 compilation check to reduce PR build time.
/cc @JoshRosen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/liancheng/spark spark-5177
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3980.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3980
----
commit 69a40b71fa9d90121b1f0f8a4d463f760a7f5d6f
Author: Cheng Lian <li...@databricks.com>
Date: 2015-01-09T16:24:54Z
Adds parameters for specifiying Hive and Scala version in dev/run-tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69369741
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25327/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69369731
[Test build #25327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25327/consoleFull) for PR 3980 at commit [`69a40b7`](https://github.com/apache/spark/commit/69a40b71fa9d90121b1f0f8a4d463f760a7f5d6f).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69770515
@JoshRosen Makes sense, I'll try to move all Jenkins specific code to `dev/run-tests-jenkins`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-83751233
Sorry I caused this to need a rebase by merging a recent refactoring of the scripts. Is this still live or something that can be implemented in Jenkins itself only?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69358988
[Test build #25327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25327/consoleFull) for PR 3980 at commit [`69a40b7`](https://github.com/apache/spark/commit/69a40b71fa9d90121b1f0f8a4d463f760a7f5d6f).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng closed the pull request at:
https://github.com/apache/spark/pull/3980
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69533875
It looks like the [Matrix Project Plugin](https://wiki.jenkins-ci.org/display/JENKINS/Matrix+Project+Plugin) is installed in Jenkins, so we should be able to use that to configure multiple axes for our builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-69533766
What do you think about moving the Jenkins-specific variables to `dev/run-tests-jenkins` instead of putting them in `run-tests`, since I guess these are only designed to be used in Jenkins?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5177][Build] Adds parameters for specif...
Posted by liancheng <gi...@git.apache.org>.
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/3980#issuecomment-83797419
@srowen Don't worry, I'm gradually merging changes of this PR to #4851. An [experimental Jenkins builder] [1] was also set up for this. These are still WiP because some Hive 12 tests are still failing. I'm closing this one.
[1]: https://amplab.cs.berkeley.edu/jenkins/job/Spark-Master-SBT_experimental/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org