[jira] [Commented] (AVRO-1956) C sharp build fails in docker image

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715333#comment-16715333 ] 

ASF GitHub Bot commented on AVRO-1956:
--------------------------------------

dkulp closed pull request #153: AVRO-1956 Workaround incompatibility in testing CSharp code
URL: https://github.com/apache/avro/pull/153
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/lang/csharp/build.sh b/lang/csharp/build.sh
index cb9f7fc89..a19753acc 100755
--- a/lang/csharp/build.sh
+++ b/lang/csharp/build.sh
@@ -30,7 +30,11 @@ case "$1" in
 
   test)
     xbuild
-    nunit-console Avro.nunit
+    if [[ ${INSIDE_AVRO_DOCKER} == 'Yes' ]]; then
+      nunit-console --framework=4.0 Avro.nunit
+    else
+      nunit-console Avro.nunit
+    fi
     ;;
 
   perf)
diff --git a/share/docker/Dockerfile b/share/docker/Dockerfile
index 01760554d..0de1ef73d 100644
--- a/share/docker/Dockerfile
+++ b/share/docker/Dockerfile
@@ -21,6 +21,8 @@ FROM java:7-jdk
 
 WORKDIR /root
 
+ENV INSIDE_AVRO_DOCKER Yes
+
 # Add the repository for node.js 4.x
 RUN curl -sL https://deb.nodesource.com/setup_4.x | bash -
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> C sharp build fails in docker image
> -----------------------------------
>
>                 Key: AVRO-1956
>                 URL: https://issues.apache.org/jira/browse/AVRO-1956
>             Project: Apache Avro
>          Issue Type: Bug
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>            Priority: Major
>
> When you run the build in the centos docker image you get 
> {quote}
> Unhandled Exception:
> System.ArgumentException: NUnit components for version 2.0.50727 of the CLR are not installed
> {quote}
> As noted by [~Simon24601] in the mailing list:
> {quote}
> From discussion with [~jcustenborder], it seems like the C# tests won't run
> on a Mac if we keep the --framework=4.0 in this line; removing it (as has
> been done for 1.8.2) makes the tests run. But removing it makes the tests
> fail on my system (CentOS 7).
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)