You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/07/22 23:37:14 UTC

[GitHub] [hadoop-ozone] bharatviswa504 opened a new pull request #1245: HDDS-4011. Update S3 related documentation.

bharatviswa504 opened a new pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245


   ## What changes were proposed in this pull request?
   
   HDDS-3993 created volume required for S3G during the OM startup.
   So, remove the step that s3v volume needs to be created.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-4011
   
   ## How was this patch tested?
   
   No code change. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #1245: HDDS-4011. Update S3 related documentation.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1245: HDDS-4011. Update S3 related documentation.

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459269878



##########
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##########
@@ -72,7 +72,7 @@ connecting to the SCM's UI at [http://localhost:9876](http://localhost:9876).
 
 The S3 gateway endpoint will be exposed at port 9878. You can use Ozone's S3
 support as if you are working against the real S3.  S3 buckets are stored under
-the `/s3v` volume, which needs to be created by an administrator first:
+the `/s3v` volume:
 
 ```
 docker-compose exec scm ozone sh volume create /s3v

Review comment:
       This code block can be removed, too.

##########
File path: hadoop-hdds/docs/content/interface/S3.md
##########
@@ -24,7 +24,7 @@ summary: Ozone supports Amazon's Simple Storage Service (S3) protocol. In fact,
 
 Ozone provides S3 compatible REST interface to use the object store data with any S3 compatible tools.
 
-S3 buckets are stored under the `/s3v`(Default is s3v, which can be setted through ozone.s3g.volume.name) volume, which needs to be created by an administrator first.
+S3 buckets are stored under the `/s3v`(Default is s3v, which can be setted through ozone.s3g.volume.name) volume.

Review comment:
       I think we can improve wording here:
   
   ```suggestion
   S3 buckets are stored under the `/s3v` volume.  The default name `s3v` can be changed by setting the `ozone.s3g.volume.name` config property in `ozone-site.xml`.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1245: HDDS-4011. Update S3 related documentation.

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#discussion_r459868266



##########
File path: hadoop-hdds/docs/content/start/StartFromDockerHub.md
##########
@@ -72,7 +72,7 @@ connecting to the SCM's UI at [http://localhost:9876](http://localhost:9876).
 
 The S3 gateway endpoint will be exposed at port 9878. You can use Ozone's S3
 support as if you are working against the real S3.  S3 buckets are stored under
-the `/s3v` volume, which needs to be created by an administrator first:
+the `/s3v` volume:
 
 ```
 docker-compose exec scm ozone sh volume create /s3v

Review comment:
       Thanks @bharatviswa504 for updating the patch.  I think you missed this `volume create` command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org


[GitHub] [hadoop-ozone] bharatviswa504 commented on pull request #1245: HDDS-4011. Update S3 related documentation.

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on pull request #1245:
URL: https://github.com/apache/hadoop-ozone/pull/1245#issuecomment-664779451


   Thank You @adoroszlai for the review


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org