[GitHub] [arrow] jorgecarleitao commented on a change in pull request #9278: ARROW-11330: [Rust][DataFusion] add ExpressionVisitor to encode expression walking

[GitBox <gi...@apache.org>]

jorgecarleitao commented on a change in pull request #9278:
URL: https://github.com/apache/arrow/pull/9278#discussion_r561229060



##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -422,6 +422,136 @@ impl Expr {
             nulls_first,
         }
     }
+
+    /// Performs a depth first depth first walk of an expression and

Review comment:
       ```suggestion
       /// Performs a depth first walk of an expression and
   ```

##########
File path: rust/datafusion/src/logical_plan/expr.rs
##########
@@ -422,6 +422,136 @@ impl Expr {
             nulls_first,
         }
     }
+
+    /// Performs a depth first depth first walk of an expression and
+    /// its children, calling `visitor.pre_visit` and

Review comment:
       ```suggestion
       /// its children, calling [`ExpressionVisitor::pre_visit`] and
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org