You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/12 15:18:37 UTC

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #350: Surefire 1910

Tibor17 edited a comment on pull request #350:
URL: https://github.com/apache/maven-surefire/pull/350#issuecomment-839857254


   @laeubi 
   We have to find the best names for the enums but first of all we have to realize that `getEffectiveFailIfNoTests()` is called if an error happens. The fact that this method is called at the line [1892](https://github.com/apache/maven-surefire/blob/827edf4c6bdad7892a768d1605b74b1258b27369/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1892) and the value is not used in the forked JVM and the value is passed to a [setter](https://github.com/apache/maven-surefire/blob/827edf4c6bdad7892a768d1605b74b1258b27369/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java#L1893) means that it is a hack. The field `failIfNoTests` is old one and carries a processed information from two fields. This is bad. I am not wondering that then the  method `getEffectiveFailIfNoTests()` is misleading.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org