You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/09/24 22:11:09 UTC

[GitHub] storm pull request: STORM-493: Workers inherit storm.conf.file/sto...

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/252#issuecomment-56730938
  
    The test issues we have seen with timeouts seem to show up a lot with VMs, or slow servers.  I don't really know for sure what is happening there.  The code looks like it should work I am +1 for merging this in.
    
    @Parth-Brahmbhatt writing a test for this really does sound difficult because you would have to spawn a separate process and validate that the config is passed to the new process. If you still do want a test I'll relent, but otherwise I would like to check this in.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---