You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/07/28 08:41:01 UTC
[GitHub] [beam] mosche opened a new pull request, #22485: Bugfix: Fix broken assertion in PipelineTest
mosche opened a new pull request, #22485:
URL: https://github.com/apache/beam/pull/22485
Just something I noticed accidentally, the current assertion in `PipelineTest.testReplaceAllIncomplete()` doesn't assert anything meaningful. Tests succeed even when removing `replaceAll`...
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #22485:
URL: https://github.com/apache/beam/pull/22485#discussion_r935697612
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java:
##########
@@ -407,13 +406,9 @@ public void testReplaceAll() {
new PipelineVisitor.Defaults() {
@Override
public CompositeBehavior enterCompositeTransform(Node node) {
- if (!node.isRootNode()) {
- assertThat(
- node.getTransform().getClass(),
- not(
- anyOf(
- Matchers.equalTo(GenerateSequence.class),
- Matchers.equalTo(Create.Values.class))));
+ String fullName = node.getFullName();
+ if (fullName.equals("unbounded") || fullName.equals("bounded")) {
+ assertThat(node.getTransform(), Matchers.instanceOf(EmptyFlatten.class));
Review Comment:
Rather than checking what the transform class after applying the replacement should not be (which was never the case anyways), this asserts that the resulting transform is an instance of the expected class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22485:
URL: https://github.com/apache/beam/pull/22485#issuecomment-1197873362
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #22485:
URL: https://github.com/apache/beam/pull/22485#issuecomment-1202544254
CC: @kennknowles
Could you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on code in PR #22485:
URL: https://github.com/apache/beam/pull/22485#discussion_r935638723
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java:
##########
@@ -407,13 +406,9 @@ public void testReplaceAll() {
new PipelineVisitor.Defaults() {
@Override
public CompositeBehavior enterCompositeTransform(Node node) {
- if (!node.isRootNode()) {
- assertThat(
- node.getTransform().getClass(),
- not(
- anyOf(
- Matchers.equalTo(GenerateSequence.class),
- Matchers.equalTo(Create.Values.class))));
+ String fullName = node.getFullName();
+ if (fullName.equals("unbounded") || fullName.equals("bounded")) {
+ assertThat(node.getTransform(), Matchers.instanceOf(EmptyFlatten.class));
Review Comment:
Could you explain this fix a bit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] mosche commented on a diff in pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
mosche commented on code in PR #22485:
URL: https://github.com/apache/beam/pull/22485#discussion_r935697612
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/PipelineTest.java:
##########
@@ -407,13 +406,9 @@ public void testReplaceAll() {
new PipelineVisitor.Defaults() {
@Override
public CompositeBehavior enterCompositeTransform(Node node) {
- if (!node.isRootNode()) {
- assertThat(
- node.getTransform().getClass(),
- not(
- anyOf(
- Matchers.equalTo(GenerateSequence.class),
- Matchers.equalTo(Create.Values.class))));
+ String fullName = node.getFullName();
+ if (fullName.equals("unbounded") || fullName.equals("bounded")) {
+ assertThat(node.getTransform(), Matchers.instanceOf(EmptyFlatten.class));
Review Comment:
Rather than checking what the transform class after applying the replacement should not be (which was always the case anyways), this asserts that the resulting transform is an instance of the expected class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #22485: Bugfix: Fix broken assertion in PipelineTest
Posted by GitBox <gi...@apache.org>.
aromanenko-dev merged PR #22485:
URL: https://github.com/apache/beam/pull/22485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org