You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/13 21:24:08 UTC
[GitHub] [spark] DavidToneian opened a new pull request #27569:
[SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on
Windows.
DavidToneian opened a new pull request #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569
This commit is published into the public domain.
### What changes were proposed in this pull request?
In analogy to `python/docs/Makefile`, which has
> export PYTHONPATH=$(realpath ..):$(realpath ../lib/py4j-0.10.8.1-src.zip)
on line 10, this PR adds
> set PYTHONPATH=..;..\lib\py4j-0.10.8.1-src.zip
to `make2.bat`.
Since there is no `realpath` in default installations of Windows, I left the relative paths unresolved. Per the instructions on how to build docs, `make.bat` is supposed to be run from `python/docs` as the working directory, so this should probably not cause issues (`%BUILDDIR%` is a relative path as well.)
### Why are the changes needed?
When building the PySpark documentation on Windows, by changing directory to `python/docs` and running `make.bat` (which runs `make2.bat`), the majority of the documentation may not be built if pyspark is not in the default `%PYTHONPATH%`. Sphinx then reports that `pyspark` (and possibly dependencies) cannot be imported.
If `pyspark` is in the default `%PYTHONPATH%`, I suppose it is that version of `pyspark` – as opposed to the version found above the `python/docs` directory – that is considered when building the documentation, which may result in documentation that does not correspond to the development version one is trying to build.
### Does this PR introduce any user-facing change?
No.
### How was this patch tested?
Manual tests on my Windows 10 machine. Additional tests with other environments very welcome!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27569: [SPARK-30823] Set
`%PYTHONPATH%` when building PySpark documentation on Windows.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586082547
Yes, I noticed this too but couldn't have a time to test it out and fix in my Windows machine. Thanks for fixing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569: [SPARK-30823] Set
`%PYTHONPATH%` when building PySpark documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-585981736
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on
Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-585981736
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586093280
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569: [SPARK-30823] Set
`%PYTHONPATH%` when building PySpark documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-585982254
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586084661
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586084664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23147/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27569: [SPARK-30823] Set
`%PYTHONPATH%` when building PySpark documentation on Windows.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586082560
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586093283
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118390/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586083897
**[Test build #118390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118390/testReport)** for PR 27569 at commit [`bf47971`](https://github.com/apache/spark/commit/bf479715488c9984874612bae3287a52b91ca2d2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586096729
Merged to master, branch-3.0, and branch-2.4.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586083897
**[Test build #118390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118390/testReport)** for PR 27569 at commit [`bf47971`](https://github.com/apache/spark/commit/bf479715488c9984874612bae3287a52b91ca2d2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586092747
**[Test build #118390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118390/testReport)** for PR 27569 at commit [`bf47971`](https://github.com/apache/spark/commit/bf479715488c9984874612bae3287a52b91ca2d2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on
Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-585982254
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586084664
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23147/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586093280
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586093283
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118390/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27569:
[SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark
documentation on Windows.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27569: [SPARK-30823][PYTHON][DOCS] Set `%PYTHONPATH%` when building PySpark documentation on Windows.
URL: https://github.com/apache/spark/pull/27569#issuecomment-586084661
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org