You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/17 22:54:23 UTC

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3860: Refactor `Expr::GetIndexedField` to use a struct

andygrove commented on code in PR #3860:
URL: https://github.com/apache/arrow-datafusion/pull/3860#discussion_r997573350


##########
datafusion/expr/src/expr.rs:
##########
@@ -324,6 +319,20 @@ impl Like {
     }
 }
 
+#[derive(Clone, PartialEq, Eq, Hash)]
+pub struct GetIndexedField {

Review Comment:
   I think we can just re-use the docs from the `Expr::GetIndexField` enum variant here:
   
   ```suggestion
   /// Returns the field of a [`arrow::array::ListArray`] or [`arrow::array::StructArray`] by key
   pub struct GetIndexedField {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org