You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/25 07:01:28 UTC

[GitHub] [airflow] potiuk opened a new pull request #6429: [AIRFLOW-5754] Improved RAT checking

potiuk opened a new pull request #6429: [AIRFLOW-5754] Improved RAT checking
URL: https://github.com/apache/airflow/pull/6429
 
 
   All files are mounted in CI now and checked using the RAT tool.
   As opposed to only the runtime-needed files. This is enabled for CI
   build only as mounting all local files to Docker (especially on Mac)
   has big performance penalty when running the checks (slow osxfs
   volume and thousands of small node_modules files generated make the
   check runs for a number of minutes). The RAT checks will by default
   use the selective volumes but on CI they will mount the whole
   source directory.
   
   Also latest version of RAT tool is used now and the output - list
   of checked files - is additionally printed as output of the RAT
   check so that we are sure the files we expect to be there, are
   actually verified.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5754
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services