[GitHub] [dubbo-go] ztelur commented on a change in pull request #1297: fix:#1143 Feature/reduce etcd registry conn

[GitBox <gi...@apache.org>]

ztelur commented on a change in pull request #1297:
URL: https://github.com/apache/dubbo-go/pull/1297#discussion_r665826496



##########
File path: remoting/etcdv3/facade.go
##########
@@ -46,54 +43,16 @@ type clientFacade interface {
 
 // HandleClientRestart keeps the connection between client and server
 func HandleClientRestart(r clientFacade) {
-	var (
-		err       error
-		failTimes int
-	)
-
 	defer r.WaitGroup().Done()

Review comment:
       r.WaitGroup()的done，wait和add使用散落在各处，remoting作为基础组件，是否可能有同学直接调用 HandleClientRestart ，然后函数结束出现 negative 的问题？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org