[jira] [Commented] (BEAM-2446) restrict scope of BeamSqlEnv in dsl query

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16051145#comment-16051145 ] 

ASF GitHub Bot commented on BEAM-2446:
--------------------------------------

GitHub user XuMingmin opened a pull request:

    https://github.com/apache/beam/pull/3372

    [BEAM-2446] restrict scope of BeamSqlEnv in dsl query

    R: @xumingming @takidau 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/XuMingmin/beam BEAM-2446

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3372.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3372
    
----
commit eb5852bd258212f3b50d760ea2b63bbcbd55c481
Author: mingmxu <mi...@ebay.com>
Date:   2017-06-14T18:50:31Z

    restrict the scope of BeamSqlEnv

----


> restrict scope of BeamSqlEnv in dsl query
> -----------------------------------------
>
>                 Key: BEAM-2446
>                 URL: https://issues.apache.org/jira/browse/BEAM-2446
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: dsl_sql_merge
>
> Currently, the scope of BeamSqlEnv is global, that means all tables are accesible for each query, although it may not be related to the input PCollections in DSL methods.
> For BeamSqlCli, it's reasonable to have a session BeamSqlEnv for each SQL client. 
> For BeamSql, each query should have its own BeamSqlEnv, which only has the input tables/PCollections.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)