You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2023/12/11 17:00:47 UTC

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20768


Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.

Testing:
 - Added end-to-end test cases with restarting of Catalog server,
   and catalogd HA failover.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/custom_cluster/test_ext_data_sources.py
9 files changed, 266 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20768/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14831/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Fri, 22 Dec 2023 23:27:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@993
PS6, Line 993: op Da
> Added a comment. Impala database has no reference with data source, only ex
Thanks for the explanation!



-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 06:39:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
gsingh@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 13 Dec 2023 21:18:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.

Testing:
 - Added end-to-end test cases with restarting of Catalog server,
   and catalogd HA failover.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/custom_cluster/test_ext_data_sources.py
11 files changed, 271 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20768/4
-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 7:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@993
PS6, Line 993: op Da
> Could you add a comment for why we use false here? The argument name is 'ch
Added a comment. Impala database has no reference with data source, only existing external data source tables have reference with data source, but we copy the properties of data source to table properties of the referenced DataSource tables so it's safe to drop data source object without checking its reference. It will not affect existing tables.


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1925
PS6, Line 1925:       dataSrc.setCatalogVersion(incrementAndGetCatalogVersion());
> Can we add a log when all these are done? E.g. "Finished refreshing DataSou
Added log message.


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2512
PS6, Line 2512: 
> nit: remove "else {" since the if-branch will always return.
fixed


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6250
PS6, Line 6250: 
> nit: "DataSource"
fixed



-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 05:58:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10100/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 18:21:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 9
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 07:56:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java
File fe/src/main/java/org/apache/impala/catalog/DataSource.java:

http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@20
PS4, Line 20: import org.apache.impala.thrift.TCatalogObject;
> This class doesn't exist in Apache Hive 3.1. We need to move some codes int
Thanks to catch this issue. Move all DataConnector related code to MetastoreShim of CDP Hive in fe/src/compat-hive-3/


http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@100
PS4, Line 100: 
             : 
             : 
> nit: remove the else-branch and "return null" directly.
Fixed.



-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jan 2024 22:55:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14645/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Dec 2023 17:29:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 6: Code-Review+1

(4 comments)

LGTM. I just have some minor comments.

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@993
PS6, Line 993: false
Could you add a comment for why we use false here? The argument name is 'checkReferences' but I'm unclear how to use it.


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@1925
PS6, Line 1925:     }
Can we add a log when all these are done? E.g. "Finished refreshing DataSources. Added 20. Removed 10."


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2512
PS6, Line 2512:  else {
nit: remove "else {" since the if-branch will always return.


http://gerrit.cloudera.org:8080/#/c/20768/6/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6250
PS6, Line 6250: function
nit: "DataSource"



-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 04:33:36 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java
File fe/src/main/java/org/apache/impala/catalog/DataSource.java:

http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@20
PS4, Line 20: import org.apache.hadoop.hive.metastore.api.DataConnector;
This class doesn't exist in Apache Hive 3.1. We need to move some codes into MetastoreShim of CDP Hive in fe/src/compat-hive-3/

Verified by this job: https://jenkins.impala.io/job/all-build-options-ub2004/598
It runs with "export USE_APACHE_HIVE=true".

04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[20,44] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: package org.apache.hadoop.hive.metastore.api
04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[75,10] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: class org.apache.impala.catalog.DataSource
04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/DataSource.java:[85,46] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: class org.apache.impala.catalog.DataSource
04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:[56,44] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: package org.apache.hadoop.hive.metastore.api
04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:[71,44] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: package org.apache.hadoop.hive.metastore.api
04:18:29 [ERROR] /home/ubuntu/Impala/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:[6223,43] cannot find symbol
04:18:29 [ERROR]   symbol:   class DataConnector
04:18:29 [ERROR]   location: package org.apache.hadoop.hive.metastore.api


http://gerrit.cloudera.org:8080/#/c/20768/4/fe/src/main/java/org/apache/impala/catalog/DataSource.java@100
PS4, Line 100:  else {
             :       return null;
             :     }
nit: remove the else-branch and "return null" directly.



-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 30 Dec 2023 04:35:52 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted and user needs to recreate DataSource objects before creating
new external DataSource tables.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.
Note that this feature is not supported for Apache Hive 3.1 and older
version.

Testing:
 - Added two end-to-end unit tests with restarting of Catalog server,
   and catalogd HA failover.
   These two tests are skipped when USE_APACHE_HIVE is set as true
   and Apache Hive version is 3.x or older version.
 - Passed all-build-options-ub2004.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Reviewed-on: http://gerrit.cloudera.org:8080/20768
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Wenzhe Zhou <wz...@cloudera.com>
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/common/skip.py
M tests/custom_cluster/test_ext_data_sources.py
13 files changed, 343 insertions(+), 17 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Wenzhe Zhou: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 10
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 23:08:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.

Testing:
 - Added end-to-end test cases with restarting of Catalog server,
   and catalogd HA failover.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSource.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/custom_cluster/test_ext_data_sources.py
9 files changed, 266 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20768/3
-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 3
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.
Note that this feature is not supported for Apache Hive 3.1 and older
version.

Testing:
 - Added two end-to-end unit tests with restarting of Catalog server,
   and catalogd HA failover.
   These two tests are skipped when USE_APACHE_HIVE is set as true
   and Apache Hive version is 3.x or older version.
 - Passed all-build-options-ub2004.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/common/skip.py
M tests/custom_cluster/test_ext_data_sources.py
13 files changed, 336 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20768/6
-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10103/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 9
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 03:18:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 9
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 03:18:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14845/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 06:25:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14840/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 4
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Sat, 30 Dec 2023 01:11:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/14842/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 6
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jan 2024 23:21:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................

IMPALA-12375: Make DataSource Object persistent

DataSource objects are saved in-memory cache in Catalog server. They are
not persisted to the HMS. The objects are lost after Catalog server is
restarted and user needs to recreate DataSource objects before creating
new external DataSource tables.
This patch makes DataSource Object persistent by saving DataSource
objects as DataConnector objects with type "impalaDataSource" in HMS.
Since HMS events for DataConnector are not handled, Catalog server
has to refresh DataSource objects when the catalogd becomes active.
Note that this feature is not supported for Apache Hive 3.1 and older
version.

Testing:
 - Added two end-to-end unit tests with restarting of Catalog server,
   and catalogd HA failover.
   These two tests are skipped when USE_APACHE_HIVE is set as true
   and Apache Hive version is 3.x or older version.
 - Passed all-build-options-ub2004.
 - Passed core test.

Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
---
M be/src/catalog/catalog-server.cc
M be/src/catalog/catalog.cc
M be/src/catalog/catalog.h
M fe/src/compat-apache-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java
M fe/src/main/java/org/apache/impala/analysis/CreateTableDataSrcStmt.java
M fe/src/main/java/org/apache/impala/catalog/Catalog.java
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/JniCatalog.java
M tests/common/skip.py
M tests/custom_cluster/test_ext_data_sources.py
13 files changed, 343 insertions(+), 17 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/20768/7
-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 7
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 8
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 03:17:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12375: Make DataSource Object persistent

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/20768 )

Change subject: IMPALA-12375: Make DataSource Object persistent
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/20768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I500a99142bb62ce873e693d573064ad4ffa153ab
Gerrit-Change-Number: 20768
Gerrit-PatchSet: 9
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <gs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 03:25:08 +0000
Gerrit-HasComments: No