[jira] [Closed] (FLINK-11167) Optimize RocksDBList#put for no empty input

["Stefan Richter (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Richter closed FLINK-11167.
----------------------------------
       Resolution: Implemented
    Fix Version/s: 1.9.0

Merged in:
master: 03faeb9

> Optimize RocksDBList#put for no empty input
> -------------------------------------------
>
>                 Key: FLINK-11167
>                 URL: https://issues.apache.org/jira/browse/FLINK-11167
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / State Backends
>            Reporter: Congxian Qiu(klion26)
>            Assignee: Congxian Qiu(klion26)
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In `RocksDBListState.putInternal` we will first remove the current state and then add the new list if needed(list is no empty) such as below.
> I think if the list is not empty, we could {color:#FF0000}skip the remove operation{color}.
>  
> {code:java}
> public void updateInternal(List<V> values) {
>    Preconditions.checkNotNull(values, "List of values to add cannot be null.");
>    clear();
>    if (!values.isEmpty()) {
>       try {
>          writeCurrentKeyWithGroupAndNamespace();
>          byte[] key = dataOutputView.getCopyOfBuffer();
>          byte[] premerge = getPreMergedValue(values, elementSerializer, dataOutputView);
>          backend.db.put(columnFamily, writeOptions, key, premerge);
>       } catch (IOException | RocksDBException e) {
>          throw new FlinkRuntimeException("Error while updating data to RocksDB", e);
>       }
>    }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)