You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by pritisarap12 <gi...@git.apache.org> on 2015/06/22 13:18:18 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8576: Skip tests for LXC
GitHub user pritisarap12 opened a pull request:
https://github.com/apache/cloudstack/pull/506
CLOUDSTACK-8576: Skip tests for LXC
Skipping testcases for LXC as it doesn't support snapshots and templates creation also excluded unittest as it was not used.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pritisarap12/cloudstack resourceLimits
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit 5c8922e640e7ebe5dedc378779ef465987606ef7
Author: pritisarap12 <pr...@clogeny.com>
Date: 2015-06-22T11:14:07Z
CLOUDSTACK-8576: Skip tests as snapshots and template are not supported on LXC
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack pull request: CLOUDSTACK-8576: Skip tests for LXC
Posted by Sanjeev N <sa...@apache.org>.
Please ignore my comment. I confirmed with Kishan and he said template
creation from volume is not supported in LXC.
On Mon, Jun 22, 2015 at 5:45 PM, sanju1010 <gi...@git.apache.org> wrote:
> Github user sanju1010 commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/506#discussion_r32927724
>
> --- Diff: test/integration/component/test_resource_limits.py ---
> @@ -748,6 +748,8 @@ def test_05_templates_per_account(self):
> # should be denied to create more than 1 template.
> # 3. Try to create 2 templates in account 2. Verify account 2
> should be
> # able to create template without any error
> + if self.hypervisor.lower() in ['lxc']:
> --- End diff --
>
> I think template creation from volume is supported in lxc.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cloudstack pull request: CLOUDSTACK-8576: Skip tests for LXC
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/506#discussion_r32927724
--- Diff: test/integration/component/test_resource_limits.py ---
@@ -748,6 +748,8 @@ def test_05_templates_per_account(self):
# should be denied to create more than 1 template.
# 3. Try to create 2 templates in account 2. Verify account 2 should be
# able to create template without any error
+ if self.hypervisor.lower() in ['lxc']:
--- End diff --
I think template creation from volume is supported in lxc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8576: Skip tests for LXC
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---