You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/08/24 23:57:44 UTC

Review Request 61899: Added HOST_PATH volume source protobuf.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61899/
-----------------------------------------------------------

Review request for mesos, Gilbert Song and Joseph Wu.


Bugs: MESOS-7306
    https://issues.apache.org/jira/browse/MESOS-7306


Repository: mesos


Description
-------

Added HOST_PATH volume source protobuf.


Diffs
-----

  include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
  include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 


Diff: https://reviews.apache.org/r/61899/diff/1/


Testing
-------

make check


Thanks,

Jie Yu

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

Posted by Jie Yu <yu...@gmail.com>.


> On Aug. 28, 2017, 6:58 p.m., Joseph Wu wrote:
> > include/mesos/mesos.proto
> > Lines 2516-2518 (original), 2516-2518 (patched)
> > <https://reviews.apache.org/r/61899/diff/1/?file=1803362#file1803362line2516>
> >
> >     Does this new enum deprecate this `host_path` field?  
> >     
> >     The only difference is that the new enum only takes absolute paths whereas the existing `host_path` can be relative (according to the comments).

We cannot deprecate it yet because SANDBOX_PATH (SELF TYPE) still use this field. i'll mark it as deprecated later once I refactor the sandbox_path volume as well (soon).


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61899/#review183972
-----------------------------------------------------------


On Aug. 24, 2017, 11:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61899/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 11:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HOST_PATH volume source protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
>   include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
> 
> 
> Diff: https://reviews.apache.org/r/61899/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61899/#review183972
-----------------------------------------------------------




include/mesos/mesos.proto
Lines 2516-2518 (original), 2516-2518 (patched)
<https://reviews.apache.org/r/61899/#comment260011>

    Does this new enum deprecate this `host_path` field?  
    
    The only difference is that the new enum only takes absolute paths whereas the existing `host_path` can be relative (according to the comments).


- Joseph Wu


On Aug. 24, 2017, 4:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61899/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HOST_PATH volume source protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
>   include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
> 
> 
> Diff: https://reviews.apache.org/r/61899/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Re: Review Request 61899: Added HOST_PATH volume source protobuf.

Posted by Joseph Wu <jo...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61899/#review184013
-----------------------------------------------------------


Ship it!




Ship It!

- Joseph Wu


On Aug. 24, 2017, 4:57 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61899/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2017, 4:57 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Joseph Wu.
> 
> 
> Bugs: MESOS-7306
>     https://issues.apache.org/jira/browse/MESOS-7306
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added HOST_PATH volume source protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 86936cf9ad9406fa4c3358ccb3c58e2f3259d65f 
>   include/mesos/v1/mesos.proto 20d9ecff68465c6517a5a239a4bd0f42f82d0cc6 
> 
> 
> Diff: https://reviews.apache.org/r/61899/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>