You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Christos Malliaridis (Jira)" <ji...@apache.org> on 2025/04/23 15:18:00 UTC

[jira] [Comment Edited] (SOLR-17567) Improve Stream CLI implementation

    [ https://issues.apache.org/jira/browse/SOLR-17567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946738#comment-17946738 ] 

Christos Malliaridis edited comment on SOLR-17567 at 4/23/25 3:17 PM:
----------------------------------------------------------------------

Were the changes backported to 9x to set the version correctly? I believe most of the changes were intended for Solr 10. Feel free to update the fixed version if I am wrong.


was (Author: JIRAUSER305622):
Were the changes backported to 9x to set the version correctly?

> Improve Stream CLI implementation
> ---------------------------------
>
>                 Key: SOLR-17567
>                 URL: https://issues.apache.org/jira/browse/SOLR-17567
>             Project: Solr
>          Issue Type: Improvement
>          Components: cli
>            Reporter: Christos Malliaridis
>            Priority: Major
>              Labels: cli, pull-request-available, streams
>             Fix For: main (10.0)
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> The current implemention for the CLI's Streams command that was introduced in SOLR-14673 has multiple issues that should be addressed, including but not limited to:
> - Use of raw strings in {{Option#getOptionValue()}}
> - Overlapping options ({{\-f}} and {{\-e}})
> - Multiple type suppressions that can be avoided
> - A bug that causes specific bats tests to fail
> - StreamTool.LocalCatStream overrides CatStream btu does not properly set commaDelimitedFilepaths (this may be a bug)
> - Obsolete LetStream#getLetParams() was introduced
> - Function StreamTool.constructStream seems obsolete and occurrences can be replaced with implementation
> - Implementation of StreamTool.readExpression does not take leading spaces infront of comment lines into account
> - Implementation of StreamTool.readExpression does not support {{*/}} at the end of line



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org