You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/15 10:33:31 UTC
[GitHub] [ozone] guohao-rosicky opened a new pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
guohao-rosicky opened a new pull request #2842:
URL: https://github.com/apache/ozone/pull/2842
Use the new PipelineChoosePolicy in Ozone Streaming
jira: https://issues.apache.org/jira/browse/HDDS-5928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#issuecomment-976222600
@guohao-rosicky ,I just moved HDDS-5928 out from HDDS-4454. Please remove "[Ozone-Streaming]" from the title of this pull request. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on a change in pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#discussion_r754210565
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -163,6 +163,8 @@
private Predicate<LayoutVersionProto> layoutMatchCondition;
private Predicate<LayoutVersionProto> layoutMisMatchCondition;
+ private final ConfigurationSource configuration;
Review comment:
Don't add this field. Pass the conf in the CapacityPipelineChoosePolicy constructor.
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/choose/algorithms/PipelineChoosePolicyFactory.java
##########
@@ -45,6 +46,18 @@ private PipelineChoosePolicyFactory() {
}
public static PipelineChoosePolicy getPolicy(
+ ConfigurationSource conf, NodeStateManager nodeStateManager)
+ throws SCMException {
+ ScmConfig scmConfig = conf.getObject(ScmConfig.class);
+ if (scmConfig.getPipelineChoosePolicyName()
+ .equals(CapacityPipelineChoosePolicy.class.getName())) {
+ return new CapacityPipelineChoosePolicy(nodeStateManager);
Review comment:
Pass the conf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] szetszwo commented on pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#issuecomment-976223414
Actually, you may need to create another pull request for merging to the master branch but not the HDDS-4454 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#issuecomment-975574528
> @guohao-rosicky , thanks for working on this.
>
> * First of all, this is not specific to Ozone-Streaming so that we should move this out from [HDDS-4454](https://issues.apache.org/jira/browse/HDDS-4454) and merge this to the master branch directly.
> * Please describe the details (How it chooses new pipeline? What are the rules?) of the new CapacityPipelineChoosePolicy and provide a few examples in the JIRA.
Okay, how do I transfer jira out? Do I have to resubmit it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on a change in pull request #2842: HDDS-5928. [Ozone-Streaming] Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on a change in pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#discussion_r754317273
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java
##########
@@ -163,6 +163,8 @@
private Predicate<LayoutVersionProto> layoutMatchCondition;
private Predicate<LayoutVersionProto> layoutMisMatchCondition;
+ private final ConfigurationSource configuration;
Review comment:
Thank you. I'll modify it and update JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guohao-rosicky commented on pull request #2842: HDDS-5928. Use the new PipelineChoosePolicy in Ozon…
Posted by GitBox <gi...@apache.org>.
guohao-rosicky commented on pull request #2842:
URL: https://github.com/apache/ozone/pull/2842#issuecomment-979704922
> Actually, you may need to create another pull request for merging to the master branch but not the [HDDS-4454](https://issues.apache.org/jira/browse/HDDS-4454) branch.
It has been modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org