You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2017/11/06 00:51:11 UTC

[GitHub] zeppelin pull request #2651: ZEPPELIN-3034. Only apply dynamic form for Livy...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2651

    ZEPPELIN-3034. Only apply dynamic form for LivySqlnterpreter

    ### What is this PR for?
    
    Simple PR to only apply dynamic forms for LivySqlInterpreter, this make the behavior consistent with zeppelin's built-in spark interpreter.
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3034
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?  No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3034

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2651
    
----
commit 39eff3757db86eac144056c7e5e21299071293b9
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-11-05T11:35:14Z

    ZEPPELIN-3034. Only apply dynamic form for LivySqlnterpreter

----


---

[GitHub] zeppelin issue #2651: ZEPPELIN-3034. Only apply dynamic form for LivySqlnter...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2651
  
    LGTM!


---

[GitHub] zeppelin issue #2651: ZEPPELIN-3034. Only apply dynamic form for LivySqlnter...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2651
  
    LGTM


---

[GitHub] zeppelin issue #2651: ZEPPELIN-3034. Only apply dynamic form for LivySqlnter...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2651
  
    Thanks @Leemoonsoo @prabhjyotsingh for review, will merge if no more discussion.


---

[GitHub] zeppelin issue #2651: ZEPPELIN-3034. Only apply dynamic form for LivySqlnter...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2651
  
    @prabhjyotsingh Could you help review this ? Thanks


---

[GitHub] zeppelin pull request #2651: ZEPPELIN-3034. Only apply dynamic form for Livy...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2651


---