[GitHub] [pinot] abhioncbr commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.

["abhioncbr (via GitHub)" <gi...@apache.org>]

abhioncbr commented on code in PR #10514:
URL: https://github.com/apache/pinot/pull/10514#discussion_r1161049540


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java:
##########
@@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode) {
     } else if (rexNode instanceof RexLiteral) {
       RexLiteral rexLiteral = ((RexLiteral) rexNode);
       FieldSpec.DataType dataType = RelToStageConverter.convertToFieldSpecDataType(rexLiteral.getType());
+      //Added to set the DataType as UNKNOWN

Review Comment:
   @61yao, After setting the `UNKNOWN` datatype, the value gets set as String `null`., which later fails for the Numeric data type. 
   I think you have made some changes in a couple of your PR. Do you think, once your PR will be merged this works fine?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org