You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tz...@apache.org on 2020/02/04 03:59:41 UTC

[flink-statefun] 02/04: [hotfix] [kafka-io] Omit get-* prefix from getters to conform with code styles

This is an automated email from the ASF dual-hosted git repository.

tzulitai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink-statefun.git

commit d23aa629149f1d4169fe98fef94f58da36ea053f
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
AuthorDate: Sat Feb 1 15:20:07 2020 +0800

    [hotfix] [kafka-io] Omit get-* prefix from getters to conform with code styles
---
 .../org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java | 4 ++--
 .../apache/flink/statefun/sdk/kafka/KafkaIngressStartupPosition.java  | 4 ++--
 .../java/org/apache/flink/statefun/sdk/kafka/testutils/Matchers.java  | 2 --
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java b/statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java
index f42f762..1fc61dc 100644
--- a/statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java
+++ b/statefun-flink/statefun-flink-io-bundle/src/main/java/org/apache/flink/statefun/flink/io/kafka/KafkaSourceProvider.java
@@ -63,10 +63,10 @@ public class KafkaSourceProvider implements SourceProvider {
       KafkaIngressStartupPosition.SpecificOffsetsPosition offsetsPosition =
           startupPosition.asSpecificOffsets();
       consumer.setStartFromSpecificOffsets(
-          convertKafkaTopicPartitionMap(offsetsPosition.getSpecificOffsets()));
+          convertKafkaTopicPartitionMap(offsetsPosition.specificOffsets()));
     } else if (startupPosition.isDate()) {
       KafkaIngressStartupPosition.DatePosition datePosition = startupPosition.asDate();
-      consumer.setStartFromTimestamp(datePosition.getEpochMilli());
+      consumer.setStartFromTimestamp(datePosition.epochMilli());
     } else {
       throw new IllegalStateException("Safe guard; should not occur");
     }
diff --git a/statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressStartupPosition.java b/statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressStartupPosition.java
index 42754dd..c6cf2f0 100644
--- a/statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressStartupPosition.java
+++ b/statefun-kafka-io/src/main/java/org/apache/flink/statefun/sdk/kafka/KafkaIngressStartupPosition.java
@@ -178,7 +178,7 @@ public class KafkaIngressStartupPosition {
       this.specificOffsets = specificOffsets;
     }
 
-    public Map<KafkaTopicPartition, Long> getSpecificOffsets() {
+    public Map<KafkaTopicPartition, Long> specificOffsets() {
       return specificOffsets;
     }
 
@@ -212,7 +212,7 @@ public class KafkaIngressStartupPosition {
       this.date = date;
     }
 
-    public long getEpochMilli() {
+    public long epochMilli() {
       return date.toInstant().toEpochMilli();
     }
 
diff --git a/statefun-kafka-io/src/test/java/org/apache/flink/statefun/sdk/kafka/testutils/Matchers.java b/statefun-kafka-io/src/test/java/org/apache/flink/statefun/sdk/kafka/testutils/Matchers.java
index 198d946..71ddce9 100644
--- a/statefun-kafka-io/src/test/java/org/apache/flink/statefun/sdk/kafka/testutils/Matchers.java
+++ b/statefun-kafka-io/src/test/java/org/apache/flink/statefun/sdk/kafka/testutils/Matchers.java
@@ -28,8 +28,6 @@ public final class Matchers {
 
   private Matchers() {}
 
-  private Matchers() {}
-
   public static <K, V> Matcher<Map<K, V>> isMapOfSize(int size) {
     return new TypeSafeMatcher<Map<K, V>>() {
       @Override