You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "Driesprong, Fokko" <fo...@driesprong.frl> on 2019/10/23 13:31:53 UTC
Stalebot
Hi all,
I would suggest enabling Stalebot on the parquet-mr repo:
https://probot.github.io/apps/stale/
Right now we have a lot of stale PR's there which have many conflicts and
are not very likely to get merged anytime soon. The stalebot will mark the
Pull Request as stale after 60 days of inactivity, and close it after a
week if there isn't any further activity. This will reduce the number of
stale repositories.
What do you think?
Cheers, Fokko
Re: Stalebot
Posted by "Driesprong, Fokko" <fo...@driesprong.frl>.
Okay, I won't enable such a bot.
I have good experiences with it at Airflow. It isn't very aggressive with
the closing, it will first ping you, and then it will be closed. If there
is any activity again, then it will take again 60 days for the ping. Also,
you can add a label to let stalebot know that it shouldn't touch that PR.
But I see the point that the Parquet doesn't have too much volume in terms
of PR's.
Cheers, Fokko
Op do 24 okt. 2019 om 00:36 schreef Wes McKinney <we...@gmail.com>:
> I also don't know that I see the value of such a bot in parquet-mr --
> the volume of PRs (especially low quality PRs, which can be an issue
> in other projects) is not that high. I would suggest a one-time
> cleaning of the parquet-mr queue and being a bit more aggressive going
> forward about closing stale PRs.
>
> On Wed, Oct 23, 2019 at 9:50 AM Michael Heuer <he...@gmail.com> wrote:
> >
> > I personally would rather we not use such a bot.
> >
> > If there are long running pull requests, ping the author and ask if the
> changes are still relevant, and if so, ask the author to rebase.
> >
> >
> > > On Oct 23, 2019, at 9:12 AM, Xinli shang <sh...@uber.com.INVALID>
> wrote:
> > >
> > > Agree with Junjie for the longer limit. We have several long running
> > > projects going on. Is there a white list with which we can bypass those
> > > projects?
> > >
> > > On Wed, Oct 23, 2019 at 7:01 AM Junjie Chen <ch...@gmail.com>
> > > wrote:
> > >
> > >> Sounds good to have it. We might want to set the expiration limit to a
> > >> larger value according to commit history.
> > >>
> > >> Driesprong, Fokko <fo...@driesprong.frl> 于2019年10月23日周三 下午9:32写道：
> > >>>
> > >>> Hi all,
> > >>>
> > >>> I would suggest enabling Stalebot on the parquet-mr repo:
> > >>>
> > >>
> https://urldefense.proofpoint.com/v2/url?u=https-3A__probot.github.io_apps_stale_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=waE-QM8dEvNWOZVGIHKxSp6iLXF-rbGKmTghRDqrPoA&s=KPKNffiF3Y_HEfU3OLbnmVPqNeTmKXkmNX-KkIGlgGI&e=
> > >>>
> > >>> Right now we have a lot of stale PR's there which have many
> conflicts and
> > >>> are not very likely to get merged anytime soon. The stalebot will
> mark
> > >> the
> > >>> Pull Request as stale after 60 days of inactivity, and close it
> after a
> > >>> week if there isn't any further activity. This will reduce the
> number of
> > >>> stale repositories.
> > >>>
> > >>> What do you think?
> > >>>
> > >>> Cheers, Fokko
> > >>
> > > --
> > > Xinli Shang
> >
>
Re: Stalebot
Posted by Wes McKinney <we...@gmail.com>.
I also don't know that I see the value of such a bot in parquet-mr --
the volume of PRs (especially low quality PRs, which can be an issue
in other projects) is not that high. I would suggest a one-time
cleaning of the parquet-mr queue and being a bit more aggressive going
forward about closing stale PRs.
On Wed, Oct 23, 2019 at 9:50 AM Michael Heuer <he...@gmail.com> wrote:
>
> I personally would rather we not use such a bot.
>
> If there are long running pull requests, ping the author and ask if the changes are still relevant, and if so, ask the author to rebase.
>
>
> > On Oct 23, 2019, at 9:12 AM, Xinli shang <sh...@uber.com.INVALID> wrote:
> >
> > Agree with Junjie for the longer limit. We have several long running
> > projects going on. Is there a white list with which we can bypass those
> > projects?
> >
> > On Wed, Oct 23, 2019 at 7:01 AM Junjie Chen <ch...@gmail.com>
> > wrote:
> >
> >> Sounds good to have it. We might want to set the expiration limit to a
> >> larger value according to commit history.
> >>
> >> Driesprong, Fokko <fo...@driesprong.frl> 于2019年10月23日周三 下午9:32写道：
> >>>
> >>> Hi all,
> >>>
> >>> I would suggest enabling Stalebot on the parquet-mr repo:
> >>>
> >> https://urldefense.proofpoint.com/v2/url?u=https-3A__probot.github.io_apps_stale_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=waE-QM8dEvNWOZVGIHKxSp6iLXF-rbGKmTghRDqrPoA&s=KPKNffiF3Y_HEfU3OLbnmVPqNeTmKXkmNX-KkIGlgGI&e=
> >>>
> >>> Right now we have a lot of stale PR's there which have many conflicts and
> >>> are not very likely to get merged anytime soon. The stalebot will mark
> >> the
> >>> Pull Request as stale after 60 days of inactivity, and close it after a
> >>> week if there isn't any further activity. This will reduce the number of
> >>> stale repositories.
> >>>
> >>> What do you think?
> >>>
> >>> Cheers, Fokko
> >>
> > --
> > Xinli Shang
>
Re: Stalebot
Posted by Michael Heuer <he...@gmail.com>.
I personally would rather we not use such a bot.
If there are long running pull requests, ping the author and ask if the changes are still relevant, and if so, ask the author to rebase.
> On Oct 23, 2019, at 9:12 AM, Xinli shang <sh...@uber.com.INVALID> wrote:
>
> Agree with Junjie for the longer limit. We have several long running
> projects going on. Is there a white list with which we can bypass those
> projects?
>
> On Wed, Oct 23, 2019 at 7:01 AM Junjie Chen <ch...@gmail.com>
> wrote:
>
>> Sounds good to have it. We might want to set the expiration limit to a
>> larger value according to commit history.
>>
>> Driesprong, Fokko <fo...@driesprong.frl> 于2019年10月23日周三 下午9:32写道：
>>>
>>> Hi all,
>>>
>>> I would suggest enabling Stalebot on the parquet-mr repo:
>>>
>> https://urldefense.proofpoint.com/v2/url?u=https-3A__probot.github.io_apps_stale_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=waE-QM8dEvNWOZVGIHKxSp6iLXF-rbGKmTghRDqrPoA&s=KPKNffiF3Y_HEfU3OLbnmVPqNeTmKXkmNX-KkIGlgGI&e=
>>>
>>> Right now we have a lot of stale PR's there which have many conflicts and
>>> are not very likely to get merged anytime soon. The stalebot will mark
>> the
>>> Pull Request as stale after 60 days of inactivity, and close it after a
>>> week if there isn't any further activity. This will reduce the number of
>>> stale repositories.
>>>
>>> What do you think?
>>>
>>> Cheers, Fokko
>>
> --
> Xinli Shang
Re: Stalebot
Posted by Xinli shang <sh...@uber.com.INVALID>.
Agree with Junjie for the longer limit. We have several long running
projects going on. Is there a white list with which we can bypass those
projects?
On Wed, Oct 23, 2019 at 7:01 AM Junjie Chen <ch...@gmail.com>
wrote:
> Sounds good to have it. We might want to set the expiration limit to a
> larger value according to commit history.
>
> Driesprong, Fokko <fo...@driesprong.frl> 于2019年10月23日周三 下午9:32写道：
> >
> > Hi all,
> >
> > I would suggest enabling Stalebot on the parquet-mr repo:
> >
> https://urldefense.proofpoint.com/v2/url?u=https-3A__probot.github.io_apps_stale_&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=FQ88AmOZ4TMjDdqNBGu-ag&m=waE-QM8dEvNWOZVGIHKxSp6iLXF-rbGKmTghRDqrPoA&s=KPKNffiF3Y_HEfU3OLbnmVPqNeTmKXkmNX-KkIGlgGI&e=
> >
> > Right now we have a lot of stale PR's there which have many conflicts and
> > are not very likely to get merged anytime soon. The stalebot will mark
> the
> > Pull Request as stale after 60 days of inactivity, and close it after a
> > week if there isn't any further activity. This will reduce the number of
> > stale repositories.
> >
> > What do you think?
> >
> > Cheers, Fokko
>
--
Xinli Shang
Re: Stalebot
Posted by Junjie Chen <ch...@gmail.com>.
Sounds good to have it. We might want to set the expiration limit to a
larger value according to commit history.
Driesprong, Fokko <fo...@driesprong.frl> 于2019年10月23日周三 下午9:32写道：
>
> Hi all,
>
> I would suggest enabling Stalebot on the parquet-mr repo:
> https://probot.github.io/apps/stale/
>
> Right now we have a lot of stale PR's there which have many conflicts and
> are not very likely to get merged anytime soon. The stalebot will mark the
> Pull Request as stale after 60 days of inactivity, and close it after a
> week if there isn't any further activity. This will reduce the number of
> stale repositories.
>
> What do you think?
>
> Cheers, Fokko