You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by bu...@apache.org on 2014/06/11 17:47:50 UTC
review requested: [Issue 125071] When saving as doc, odt file
crashes and immediately recovers : [Attachment 83538] check
SwFmt::GetItemState()'s ppItem for NULL
hdu@apache.org <hd...@apache.org> has asked Oliver-Rainer Wittmann
<or...@apache.org> for review:
Issue 125071: When saving as doc, odt file crashes and immediately recovers
https://issues.apache.org/ooo/show_bug.cgi?id=125071
Attachment 83538: check SwFmt::GetItemState()'s ppItem for NULL
https://issues.apache.org/ooo/attachment.cgi?id=83538&action=edit
------- Additional Comments from hdu@apache.org <hd...@apache.org>
The SwFmt::GetItemState() method shoud check its ppItem pointer argument before
assigning something into it, because NULL is the default value according to
main/sw/inc/format.hxx and thus is allowed.
The suggested patch solves the crash for both Keith's sample document and for
the autotests, but debug logging still emits warnings like "Unhandled
SfxPoolItem with id X" which hint at a deeper problem.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org