You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/28 23:13:16 UTC
[GitHub] [beam] robinyqiu commented on a change in pull request #13588: [BEAM-11533] Add logic to convert Beam schema to DataCatalog schema to SchemaUtils
robinyqiu commented on a change in pull request #13588:
URL: https://github.com/apache/beam/pull/13588#discussion_r549514574
##########
File path: sdks/java/extensions/sql/datacatalog/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/datacatalog/SchemaUtils.java
##########
@@ -53,7 +53,7 @@
.build();
/** Convert DataCatalog schema to Beam schema. */
- static Schema fromDataCatalog(com.google.cloud.datacatalog.v1beta1.Schema dcSchema) {
+ public static Schema fromDataCatalog(com.google.cloud.datacatalog.v1beta1.Schema dcSchema) {
Review comment:
Done. PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org