[jira] [Commented] (KAFKA-6568) LogCleanerManager.doneDeleting() should check the partition state before deleting the in progress partition

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366569#comment-16366569 ] 

ASF GitHub Bot commented on KAFKA-6568:
---------------------------------------

becketqin opened a new pull request #4580: KAFKA-6568; The log cleaner should check the partition state before r…
URL: https://github.com/apache/kafka/pull/4580
 
 
   …emoving it from the inProgress map.
   
   The log cleaner should not naively remove the partition from in progress map without checking the partition state. This may cause the other thread calling `LogCleanerManager.abortAndPauseCleaning()` to hang in definitely.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> LogCleanerManager.doneDeleting() should check the partition state before deleting the in progress partition
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6568
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6568
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.1, 0.10.2.1, 1.0.0, 0.11.0.2
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>            Priority: Blocker
>             Fix For: 1.1.0
>
>
> {{LogCleanerManager.doneDeleting()}} removes the partition from the {{inProgress}} map without checking if the partition is paused or not. This will cause the paused partition state to be lost, and may also cause another thread calling {{LogCleanerManager.abortAndPauseCleaning()}} to block indefinitely waiting on the partition state to become paused.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)