You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/09 18:33:23 UTC
[GitHub] [airflow] mik-laj opened a new pull request #7117: [AIRFLOW-6520]
Simplify `airflow config` command
mik-laj opened a new pull request #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117
It is better to convert to INI using the standard library. It is more tested and more stable. I am afraid that our implementation works for edge cases.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7117: [AIRFLOW-6520]
Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7117: [AIRFLOW-6520] Simplify
`airflow config` command
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572725222
> Does it preserve comments?
I looked at the docs and it does not and I think for export of the configuration to the output that's fine.
For updating the configuration I found there is this package: https://pypi.org/project/ConfigUpdater/ that handles updates to the .ini files quite nicely, including comment preservation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#discussion_r365059091
##########
File path: airflow/cli/commands/config_command.py
##########
@@ -15,15 +15,13 @@
# specific language governing permissions and limitations
# under the License.
"""Config sub-commands"""
+import io
+
from airflow.configuration import conf
def show_config(args):
Review comment:
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #7117: [AIRFLOW-6520]
Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572706568
Does it preserve comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#discussion_r365034179
##########
File path: airflow/cli/commands/config_command.py
##########
@@ -15,15 +15,13 @@
# specific language governing permissions and limitations
# under the License.
"""Config sub-commands"""
+import io
+
from airflow.configuration import conf
def show_config(args):
Review comment:
Could we remove unuse variable `args`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.95% -0.26%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 33168 -61
- Misses 5768 5875 +107
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.82%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.38% -0.83%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 32945 -284
- Misses 5768 6098 +330
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.95% -0.26%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 33168 -61
- Misses 5768 5875 +107
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/postgres\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvcG9zdGdyZXNfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `88.43% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| ... and [27 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj merged pull request #7117: [AIRFLOW-6520]
Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#discussion_r365037217
##########
File path: airflow/cli/commands/config_command.py
##########
@@ -15,15 +15,13 @@
# specific language governing permissions and limitations
# under the License.
"""Config sub-commands"""
+import io
+
from airflow.configuration import conf
def show_config(args):
Review comment:
It is required by the function that calls these functions. Simply: All commands accept arguments. It's required.
https://github.com/apache/airflow/blob/master/airflow/bin/airflow#L39
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7117:
[AIRFLOW-6520] Simplify `airflow config` command
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7117: [AIRFLOW-6520] Simplify `airflow config` command
URL: https://github.com/apache/airflow/pull/7117#issuecomment-572711660
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=h1) Report
> Merging [#7117](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/77b1bdc12ca5ddf043d4550d36948766b59f60ce?src=pr&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7117 +/- ##
==========================================
- Coverage 85.2% 84.95% -0.26%
==========================================
Files 682 682
Lines 38997 39043 +46
==========================================
- Hits 33229 33168 -61
- Misses 5768 5875 +107
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/cli/commands/config\_command.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY29uZmlnX2NvbW1hbmQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...rflow/contrib/operators/kubernetes\_pod\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZF9vcGVyYXRvci5weQ==) | `78.75% <0%> (-20%)` | :arrow_down: |
| [...ample\_dags/example\_branch\_python\_dop\_operator\_3.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfcHl0aG9uX2RvcF9vcGVyYXRvcl8zLnB5) | `75% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/example\_subdag\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9zdWJkYWdfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/example\_branch\_operator.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9icmFuY2hfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [...w/example\_dags/example\_latest\_only\_with\_trigger.py](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV9sYXRlc3Rfb25seV93aXRoX3RyaWdnZXIucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/airflow/pull/7117/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=footer). Last update [77b1bdc...f42bdcd](https://codecov.io/gh/apache/airflow/pull/7117?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services