You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/12/18 07:21:52 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4940: Removing dependency on pinot-common and pinot-core from pinot-connect…
codecov-io commented on issue #4940: Removing dependency on pinot-common and pinot-core from pinot-connect…
URL: https://github.com/apache/incubator-pinot/pull/4940#issuecomment-566904385
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=h1) Report
> Merging [#4940](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f48370c6ed2828d4f32747bd14627f7d9496490c?src=pr&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `29.31%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4940 +/- ##
============================================
- Coverage 56.64% 56.63% -0.02%
Complexity 16 16
============================================
Files 1176 1176
Lines 62825 62790 -35
Branches 9219 9214 -5
============================================
- Hits 35586 35558 -28
+ Misses 24614 24603 -11
- Partials 2625 2629 +4
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1NlZ21lbnREZWxldGlvbk1hbmFnZXIuamF2YQ==) | `75.4% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `74.59% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/realtime/impl/kafka/KafkaAvroMessageDecoder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtY29ubmVjdG9ycy9waW5vdC1jb25uZWN0b3Ita2Fma2EtYmFzZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2thZmthL0thZmthQXZyb01lc3NhZ2VEZWNvZGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../server/starter/helix/SegmentFetcherAndLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9TZWdtZW50RmV0Y2hlckFuZExvYWRlci5qYXZh) | `64.07% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...roller/helix/core/PinotTableIdealStateBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL1Bpbm90VGFibGVJZGVhbFN0YXRlQnVpbGRlci5qYXZh) | `80.26% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...not/spi/utils/retry/AttemptsExceededException.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvcmV0cnkvQXR0ZW1wdHNFeGNlZWRlZEV4Y2VwdGlvbi5qYXZh) | `100% <ø> (ø)` | `0 <0> (?)` | |
| [...rg/apache/pinot/spi/utils/retry/RetryPolicies.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvcmV0cnkvUmV0cnlQb2xpY2llcy5qYXZh) | `20% <ø> (ø)` | `0 <0> (?)` | |
| [...ces/PinotSegmentUploadDownloadRestletResource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL1Bpbm90U2VnbWVudFVwbG9hZERvd25sb2FkUmVzdGxldFJlc291cmNlLmphdmE=) | `61.58% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/pinot/spi/utils/retry/NoDelayRetryPolicy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvcmV0cnkvTm9EZWxheVJldHJ5UG9saWN5LmphdmE=) | `100% <ø> (ø)` | `0 <0> (?)` | |
| [...in/java/org/apache/pinot/minion/MinionStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree#diff-cGlub3QtbWluaW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9taW5pb24vTWluaW9uU3RhcnRlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| ... and [54 more](https://codecov.io/gh/apache/incubator-pinot/pull/4940/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=footer). Last update [f48370c...3cdd472](https://codecov.io/gh/apache/incubator-pinot/pull/4940?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org