You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/29 11:22:20 UTC

[GitHub] [spark] cloud-fan commented on pull request #28935: [SPARK-20680][SQL] Adding HiveVoidType in Spark to be compatible with Hive

cloud-fan commented on pull request #28935:
URL: https://github.com/apache/spark/pull/28935#issuecomment-651049830


   I think we need two changes:
   1. forbid creating tables with void column type. This could be done in the rule `CommandCheck`. We can test it with `spark.catalog.createTable`
   2. support "void" in the parser to fix SPARK-20680. This is only for legacy hive tables, as new tables can't have void type columns.
   
   These two changes can be done with 2 PRs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org