You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "szaszm (via GitHub)" <gi...@apache.org> on 2023/04/05 14:00:11 UTC
[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1549: MINIFICPP-2093 Update default features/extensions
szaszm opened a new pull request, #1549:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1549
...and disable kubernetes on windows, to avoid a cmake error
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1549: MINIFICPP-2093 Update default features/extensions
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink closed pull request #1549: MINIFICPP-2093 Update default features/extensions
URL: https://github.com/apache/nifi-minifi-cpp/pull/1549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1549: MINIFICPP-2093 Update default features/extensions
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on PR #1549:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1549#issuecomment-1503569610
The windows CI failure is unrelated, due to some ODBC env issue. Do you think we can keep OPC-UA? @fgerlits @martinzink
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1549: MINIFICPP-2093 Update default features/extensions
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1549:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1549#discussion_r1158723619
##########
.github/workflows/ci.yml:
##########
Review Comment:
It came up recently in another PR that SFTP is not enabled in the `ubuntu_20_04_clang` job. Everything that can be enabled should be enabled in that job, because otherwise the `clang-tidy` job will fail if a file in a disabled extension has been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org