[GitHub] [iceberg] rdblue commented on a change in pull request #1436: add identifier check in newReplaceTableTransaction()

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #1436:
URL: https://github.com/apache/iceberg/pull/1436#discussion_r485977000



##########
File path: core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
##########
@@ -81,6 +81,7 @@ public Transaction newReplaceTableTransaction(
       String location,
       Map<String, String> properties,
       boolean orCreate) {
+    Preconditions.checkArgument(isValidIdentifier(identifier), "Invalid table identifier: %s", identifier);

Review comment:
       I think that this is already done because it uses the table builder and that has the same check on line 201.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org