[jira] [Commented] (WICKET-3564) AjaxRequestTarget#addComponent(..) should guard against improper usage

["Juergen Donnerstag (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13052467#comment-13052467 ] 

Juergen Donnerstag commented on WICKET-3564:
--------------------------------------------

Hi Martjin,

could you please build a quickstart or even better a test case and attach it. It'd avoid we break important functionality in the future again. Thanks a lot.

-Juergen

> AjaxRequestTarget#addComponent(..) should guard against improper usage
> ----------------------------------------------------------------------
>
>                 Key: WICKET-3564
>                 URL: https://issues.apache.org/jira/browse/WICKET-3564
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 1.4.17
>            Reporter: Joonas Koivunen
>            Assignee: Juergen Donnerstag
>             Fix For: 1.5-RC5
>
>         Attachments: 3564-list_comp_resp.diff
>
>
> It's possible to call ART#addComponent(...) from (for example) Component#onComponentTag(..) which will later throw ConcurrentModificationException from line 675 (getting next from iterator).
> Guarding the addComponent(Component, String) and the other add* and register* methods would seem better in the terms of fail-fast behaviour and save someone else a bit of debugging time.
> Patching this is rather trivial at least for Components; for javascripts I'm not sure if correctly blocking adding prependJs just before rendering it could break someones (already broken, unrendered) javascript?

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira