You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/24 19:00:55 UTC
[GitHub] [nifi] greyp9 opened a new pull request #5708: NIFI-9233 - Improve reliability of system integration tests
greyp9 opened a new pull request #5708:
URL: https://github.com/apache/nifi/pull/5708
#### Description of PR
Alter CI logic of `system-tests` such that they are only run on a schedule on the base repository. This is to avoid resource contention caused by repo forks also scheduling system tests to run at the same time.
When we re-enable system tests to run on pushes, we might re-evaluate this approach. It should be possible to run system tests on forks, just not on a (shared) schedule. The situation we want to avoid is having all enabled forks (potentially hundreds) simultaneously requesting macos and linux build nodes for an operation that is expected to take ~1 hour. Hopefully this will help the system-test suite to run with greater stability.
In order to avoid the potential for resource contention at 0000Z with existing forks (who have not pulled this change), adjust the daily schedule trigger time.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 closed pull request #5708: NIFI-9233 - Improve reliability of system integration tests
Posted by GitBox <gi...@apache.org>.
greyp9 closed pull request #5708:
URL: https://github.com/apache/nifi/pull/5708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on pull request #5708: NIFI-9233 - Improve reliability of system integration tests
Posted by GitBox <gi...@apache.org>.
greyp9 commented on pull request #5708:
URL: https://github.com/apache/nifi/pull/5708#issuecomment-1022620600
We eventually want to re-enable the system tests for pull requests. There doesn't seem to be a way to limit the cron trigger to a certain owner, while allowing all repo owners on a different trigger. Cancelling this PR.
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onschedule
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org