You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/26 03:56:13 UTC

[GitHub] mistercrunch commented on a change in pull request #5487: Match viz dataframe column case to form_data fields

mistercrunch commented on a change in pull request #5487: Match viz dataframe column case to form_data fields
URL: https://github.com/apache/incubator-superset/pull/5487#discussion_r205325124
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -467,6 +468,36 @@ def get_data(self, df):
     def json_data(self):
         return json.dumps(self.data)
 
+    def fix_df_column_case(self, df):
 
 Review comment:
   This doesn't really belong in `viz.py`, I'd much rather have this in `db_engine_spec.py` and only execute for these weird database. Maybe it's a method in `BaseEngineSpec` that applies conditionally based no a class attribute.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org