You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@continuum.apache.org by Brent Atkinson <br...@gmail.com> on 2013/11/30 18:54:48 UTC

Re: svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Hi Brett,

I am new to review via the commit list. If I am doing things that I can
improve upon, don't be shy to critique. I will consider the correction a
high compliment.


@@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
>      protected void goToAddDirectoryPurge()
>      {
>          goToGeneralPurgePage();
> -        assertGeneralPurgePage();
>

Is there a reason that the assert was removed here and not in the other
method?


> -        clickLinkWithXPath(
> -            "//preceding::input[@value='directory' and
> @type='hidden']//following::input[@type='submit']" );
> +        clickLinkWithXPath(
> "//form[@name='addDirPurgeConfig']/input[@type='submit']" );
>          assertAddEditDirectoryPurgePage();
>      }
>

Re: svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Posted by Brett Porter <br...@apache.org>.


Brent Atkinson wrote:
> Hi Brett,
>
> I am new to review via the commit list. If I am doing things that I can
> improve upon, don't be shy to critique. I will consider the correction a
> high compliment.

Thanks for taking a look!

>
>
> @@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
>>       protected void goToAddDirectoryPurge()
>>       {
>>           goToGeneralPurgePage();
>> -        assertGeneralPurgePage();
>>
>
> Is there a reason that the assert was removed here and not in the other
> method?

Seems I missed that - I'll remove them now.

Cheers,
Brett