[GitHub] [iceberg] JonasJ-ap commented on a diff in pull request #7358: AWS: Fix default warehouse path in Dynamodb catalog

["JonasJ-ap (via GitHub)" <gi...@apache.org>]

JonasJ-ap commented on code in PR #7358:
URL: https://github.com/apache/iceberg/pull/7358#discussion_r1167979582


##########
aws/src/integration/java/org/apache/iceberg/aws/dynamodb/TestDynamoDbCatalog.java:
##########
@@ -379,6 +379,21 @@ public void testRegisterTable() {
     Assertions.assertThat(catalog.dropNamespace(namespace)).isTrue();
   }
 
+  @Test
+  public void testDefaultWarehousePathWithLocation() {

Review Comment:
   Thank you for your contribution. I was wondering if it would be possible to add a unit test for this change in addition to the aws integration test. like:
   https://github.com/apache/iceberg/blob/b78d3361635e924ed23fd8fe87b5f966b1953dd9/aws/src/test/java/org/apache/iceberg/aws/glue/TestGlueCatalog.java#L143-L153
   Since the AWS integration test is not currently run with CI, having a unit test could help catch errors more quickly and ensure that future development reflects this change accurately. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org