You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "ptupitsyn (via GitHub)" <gi...@apache.org> on 2023/01/30 17:17:53 UTC

[GitHub] [ignite-3] ptupitsyn commented on a diff in pull request #1598: IGNITE-17992 .NET: Fix colocation hash for LocalTime, LocalDateTime, Timestamp with custom precision

ptupitsyn commented on code in PR #1598:
URL: https://github.com/apache/ignite-3/pull/1598#discussion_r1090919375


##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/row/TemporalTypesHelper.java:
##########
@@ -272,13 +272,13 @@ private static int truncateTo(int precision, int nanos) {
                 return nanos / 1_000_000; // 1ms precision.
             }
             case 4: {
-                return (nanos / 100_000) * 100; // 100mcs precision.
+                return (nanos / 100_000) * 100; // 100μs precision.
             }
             case 5: {
-                return (nanos / 10_000) * 10; // 10mcs precision.
+                return (nanos / 10_000) * 10; // 10μs precision.
             }
             case 6: {
-                return nanos / 1_000; // 1mcs precision.
+                return nanos / 1_000; // 1μs precision.

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org