You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/26 02:54:35 UTC

[GitHub] [incubator-kyuubi] Nick-0723 commented on a change in pull request #2212: [KYUUBI #2207] Support newly added spark data types: DayTimeIntervalType/YearMonthIntervalType

Nick-0723 commented on a change in pull request #2212:
URL: https://github.com/apache/incubator-kyuubi/pull/2212#discussion_r835702796



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala
##########
@@ -39,10 +39,13 @@ object SchemaHelper {
     case _: DecimalType => TTypeId.DECIMAL_TYPE
     case DateType => TTypeId.DATE_TYPE
     case TimestampType => TTypeId.TIMESTAMP_TYPE
+    case tntz if tntz.simpleString.equals("timestamp_ntz") => TTypeId.TIMESTAMP_TYPE

Review comment:
       Is TimestampNTZType's hive thrift type TTypeId.TIMESTAMP_TYPE and is jdbc type TIMESTAMP ？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org