You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@openwhisk.apache.org by gi...@git.apache.org on 2017/06/02 20:44:06 UTC

[GitHub] dubeejw commented on a change in pull request #2327: Update OPTIONS Respones for Web Actions (Review)

dubeejw commented on a change in pull request #2327: Update OPTIONS Respones for Web Actions (Review)
URL: https://github.com/apache/incubator-openwhisk/pull/2327#discussion_r119948421
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
 ##########
 @@ -328,6 +338,7 @@ trait WebActionsApiTests extends ControllerTestCommon with BeforeAndAfterEach wi
 
         it should s"not match invalid routes (auth? ${creds.isDefined})" in {
             implicit val tid = transid()
+            customOptions = true
 
 Review comment:
   The majority of the tests invoke a web action with the OPTIONS verb. In order to maintain the same test behavior I am adding the custom options annotation to those tests. We could enable the annotation by default in the tests when declaring the custonOptions value.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services