You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/12/13 16:57:56 UTC
[GitHub] [hadoop] goiri commented on a diff in pull request #5193: YARN-11374. [Federation] Support refreshSuperUserGroupsConfiguration、refreshUserToGroupsMappings API's for Federation.
goiri commented on code in PR #5193:
URL: https://github.com/apache/hadoop/pull/5193#discussion_r1047443121
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -192,11 +192,11 @@ public RefreshQueuesResponse refreshQueues(RefreshQueuesRequest request)
}
} catch (YarnException e) {
routerMetrics.incrRefreshQueuesFailedRetrieved();
- RouterServerUtil.logAndThrowException(e, "Unable to refreshQueue due to exception.");
+ throw e;
}
routerMetrics.incrRefreshQueuesFailedRetrieved();
- throw new YarnException("Unable to refreshQueue.");
+ throw new YarnException("Unable to refreshQueue due to exception.");
Review Comment:
Do we need to change this?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/rmadmin/FederationRMAdminInterceptor.java:
##########
@@ -192,11 +192,11 @@ public RefreshQueuesResponse refreshQueues(RefreshQueuesRequest request)
}
} catch (YarnException e) {
routerMetrics.incrRefreshQueuesFailedRetrieved();
- RouterServerUtil.logAndThrowException(e, "Unable to refreshQueue due to exception.");
+ throw e;
Review Comment:
No log anymore?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/server/api/protocolrecords/impl/pb/RefreshSuperUserGroupsConfigurationRequestPBImpl.java:
##########
@@ -56,8 +59,9 @@ public int hashCode() {
@Override
public boolean equals(Object other) {
- if (other == null)
+ if (other == null) {
return false;
+ }
if (other.getClass().isAssignableFrom(this.getClass())) {
return this.getProto().equals(this.getClass().cast(other).getProto());
Review Comment:
We had a cleaner way to do all this check or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org